Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Firebird] Not-null blobs and remove table names from set clause in update statement #519

Merged
merged 1 commit into from Dec 12, 2013

Conversation

Projects
None yet
2 participants
Contributor

rzane commented Dec 12, 2013

Not-null blob values were inserting null values and failing as described in #430. I basically copied the changes that were made in @47bcdcf866a6c2303d6e64cf83b8441affccf706 for the DB2 adapter.

Firebird can't have the table name in the set clause of an update statement. I added the quote_table_name_for_assignment override used in the SQLite3 adapter. (https://github.com/jruby/activerecord-jdbc-adapter/blob/master/lib/arjdbc/sqlite3/adapter.rb#L226-L228)

[Firebird] Insert quotes for blobs to prevent failed inserts on not-n…
…ull cols, Remove table names from SET clause in SQL update

kares added a commit that referenced this pull request Dec 12, 2013

Merge pull request #519 from rzane/master
[Firebird] Not-null blobs and remove table names from set clause in update statement

@kares kares merged commit 85e6402 into jruby:master Dec 12, 2013

1 check was pending

default The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment