New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RubyArray and all subclasses to pass this check. #740

Closed
wants to merge 1 commit into
base: 1-3-stable
from

Conversation

Projects
None yet
4 participants
@headius
Member

headius commented Aug 17, 2016

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Aug 18, 2016

Member

thanks for the PR I managed to miss it ... only found it after reading the comment at jruby/jruby#4080
... should be enough as an issue report thought. for the record this was resolved in AR-JDBC 1.3.21

Member

kares commented Aug 18, 2016

thanks for the PR I managed to miss it ... only found it after reading the comment at jruby/jruby#4080
... should be enough as an issue report thought. for the record this was resolved in AR-JDBC 1.3.21

@kares kares closed this Aug 18, 2016

@elthariel

This comment has been minimized.

Show comment
Hide comment
@elthariel

elthariel Oct 18, 2016

That'd be great to merge this to the rails-5 branch as well :)

elthariel commented Oct 18, 2016

That'd be great to merge this to the rails-5 branch as well :)

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Oct 18, 2016

Member

@elthariel cherry-picked at 5468b6f. Thanks for pointing that out.

@kares should we consider a merge do you think of other commits to rails-5?

Member

enebo commented Oct 18, 2016

@elthariel cherry-picked at 5468b6f. Thanks for pointing that out.

@kares should we consider a merge do you think of other commits to rails-5?

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Oct 18, 2016

Member

@enebo your call, I somehow lost track what rails-5 is based off. anyways you should be good if you're off 1-3-stable - master's "refactorings" are unfinished and not released (no plans really to work on it atm).

Member

kares commented Oct 18, 2016

@enebo your call, I somehow lost track what rails-5 is based off. anyways you should be good if you're off 1-3-stable - master's "refactorings" are unfinished and not released (no plans really to work on it atm).

@elthariel

This comment has been minimized.

Show comment
Hide comment
@elthariel

elthariel Oct 18, 2016

Thanks for the impressive reactivity !

On Tue, Oct 18, 2016 at 4:31 PM, Karol Bucek notifications@github.com
wrote:

@enebo https://github.com/enebo your call, I somehow lost track what
rails-5 is based off. anyways you should be good if you're off 1-3-stable -
master's "refactorings" are unfinished and not released (no plans really to
work on it atm).


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#740 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJa89g8yK-xDx-ckNWT1vd9IjJ1pPN6ks5q1Ng8gaJpZM4Jm0tG
.

elthariel commented Oct 18, 2016

Thanks for the impressive reactivity !

On Tue, Oct 18, 2016 at 4:31 PM, Karol Bucek notifications@github.com
wrote:

@enebo https://github.com/enebo your call, I somehow lost track what
rails-5 is based off. anyways you should be good if you're off 1-3-stable -
master's "refactorings" are unfinished and not released (no plans really to
work on it atm).


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#740 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJa89g8yK-xDx-ckNWT1vd9IjJ1pPN6ks5q1Ng8gaJpZM4Jm0tG
.

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Oct 18, 2016

Member

@kares well call me dumb but I never evaluated the difference between 1-3-stable and master. master is basically a good portion of the way to satisfying the last bit of Rails 5 work (namely that execute handles all queries/updates/inserts/...). So I may look this over and at least steal some stuff. sqlite3 adapter is 5E/5F on rails-5 and really 2 of those are missing loading Arel in tests. So I am slowly getting this green.

Member

enebo commented Oct 18, 2016

@kares well call me dumb but I never evaluated the difference between 1-3-stable and master. master is basically a good portion of the way to satisfying the last bit of Rails 5 work (namely that execute handles all queries/updates/inserts/...). So I may look this over and at least steal some stuff. sqlite3 adapter is 5E/5F on rails-5 and really 2 of those are missing loading Arel in tests. So I am slowly getting this green.

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Oct 18, 2016

Member

NP - well give it a try if you can but there's certainly some regressions (on master) I haven't looked into :(
... glad someone is finally spending some quality time on AR-JDBC 🔢 5️⃣ 5️⃣ 5️⃣ !

Member

kares commented Oct 18, 2016

NP - well give it a try if you can but there's certainly some regressions (on master) I haven't looked into :(
... glad someone is finally spending some quality time on AR-JDBC 🔢 5️⃣ 5️⃣ 5️⃣ !

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Oct 19, 2016

Member

@kares my other issue atm in using what we have is lots of deprecations on using things like quote so although what we have might pass tests it won't work for long so some of your work I think will be more of a starting point.

Member

enebo commented Oct 19, 2016

@kares my other issue atm in using what we have is lots of deprecations on using things like quote so although what we have might pass tests it won't work for long so some of your work I think will be more of a starting point.

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Oct 19, 2016

Member

@enebo honestly I did not remove that much - not sure its ben a while (mostly some really old AR 2.x relics) have concentrated on cleaning up the internal APIs ... for better speed and some less tech.debt.

Member

kares commented Oct 19, 2016

@enebo honestly I did not remove that much - not sure its ben a while (mostly some really old AR 2.x relics) have concentrated on cleaning up the internal APIs ... for better speed and some less tech.debt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment