Skip to content

Fix gbk (for JRUBY-6267)#2

Merged
BanzaiMan merged 3 commits into
jruby:masterfrom
ryenus:fix-gbk
Feb 7, 2012
Merged

Fix gbk (for JRUBY-6267)#2
BanzaiMan merged 3 commits into
jruby:masterfrom
ryenus:fix-gbk

Conversation

@ryenus

@ryenus ryenus commented Feb 6, 2012

Copy link
Copy Markdown
Contributor

oh, lord, why GBKEncoding.INSTANCE = new CP949Encoding() ?

This caused the weird bug JRUBY-6267.

@BanzaiMan

Copy link
Copy Markdown
Member

Is JUnit 4.10 necessary?

@ryenus

ryenus commented Feb 7, 2012

Copy link
Copy Markdown
Contributor Author

Yes, it's necessary. The test code needs to use org.junit.Assume.assumeTrue, which is only available in JUnit 4 (at least 4.4).

BanzaiMan added a commit that referenced this pull request Feb 7, 2012
Fix gbk (for JRUBY-6267)
@BanzaiMan BanzaiMan merged commit e36e2d8 into jruby:master Feb 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants