Various fixes #9

Open
wants to merge 4 commits into
from

Projects

None yet

4 participants

dlee commented Aug 10, 2011

Includes bug-fixes and implementation of an unimplemented method.

David Lee added some commits Aug 10, 2011
David Lee Implement PKCS7#type= b9d1dc5
David Lee Workaround strange case of split OctetStrings
OctetString can be split into a Sequence of OctetStrings. Merge them back before
passing to setEncData().
9dadbc1
David Lee Support degenerate certs-only PKCS7 ae87438
David Lee CertificationRequestInfo attribute can be a Sequence f88f3a8
Member
nahi commented Aug 11, 2011

Thanks! It would be nice if you provide tests for each fix. Can you create that?

Can we get this merged in? It fixes things for me as well.

Member
nahi commented Feb 6, 2012

@matthauck Nice, would you please give me a PKCS7 file that you use for confirmation? I can write tests and merge if I have a concrete example.

@matthauck matthauck added a commit to matthauck/jruby-ossl that referenced this pull request May 5, 2012
@matthauck matthauck Degenerate PKCS7 + split OctetString test cases
For pull request #9
a9acbd3
@matthauck matthauck added a commit to matthauck/jruby-ossl that referenced this pull request May 5, 2012
@matthauck matthauck Degenerate PKCS7 + split OctetString test cases
For pull request #9
095de1c

any hope this might get pulled in?

We also depend on these changes. How can we help to get these fixes pulled in?

It'd be really nice to get these for jruby 1.7.1, now that we do not have the option of keeping these fixes of ours in a jruby-ossl fork -- it now requires a whole jruby fork which will be more difficult to maintain.

Sweet!

@jedld jedld pushed a commit to jedld/jruby that referenced this pull request Jan 3, 2014
@headius Martin Ott + headius PKCS7 structures that have their content encapsulated in a sequence a…
…re not imported correctly

The case to handle content which has been encapsulated in a sequence
has been in place already but wasn't implemented. The fix is inspired
by Pull Request: jruby/jruby-ossl#9. The test
case includes PKCS7 samples to showcase the issue. Credit goes to Jason
Franklin [https://github.com/jamuc] for helping with the samples and
the fix in general.

Conflicts:
	test/externals/ruby1.9/openssl/test_pkcs7.rb
acdb0d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment