Digest#hexdigest should produce US-ASCII strings.

headius · headius · commit 5c6293c871e0 · 2014-11-04T16:12:50.000-06:00
diff --git a/core/src/main/java/org/jruby/ext/digest/RubyDigest.java b/core/src/main/java/org/jruby/ext/digest/RubyDigest.java
@@ -39,6 +39,7 @@
 import java.util.HashMap;
 import java.util.Map;
 
+import org.jcodings.specific.USASCIIEncoding;
 import org.jruby.Ruby;
 import org.jruby.RubyClass;
 import org.jruby.RubyFixnum;
@@ -146,7 +147,7 @@ private static ByteList toHex(byte[] val) {
     }
 
     private static IRubyObject toHexString(Ruby runtime, byte[] val) {
-        return RubyString.newStringNoCopy(runtime, ByteList.plain(toHex(val)));
+        return RubyString.newStringNoCopy(runtime, new ByteList(ByteList.plain(toHex(val)), USASCIIEncoding.INSTANCE));
     }
 
     @JRubyMethod(name = "hexencode", required = 1, meta = true)

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@`
`39`	`39`	`import java.util.HashMap;`
`40`	`40`	`import java.util.Map;`
`41`	`41`
	`42`	`+import org.jcodings.specific.USASCIIEncoding;`
`42`	`43`	`import org.jruby.Ruby;`
`43`	`44`	`import org.jruby.RubyClass;`
`44`	`45`	`import org.jruby.RubyFixnum;`
`@@ -146,7 +147,7 @@ private static ByteList toHex(byte[] val) {`
`146`	`147`	`}`
`147`	`148`
`148`	`149`	`private static IRubyObject toHexString(Ruby runtime, byte[] val) {`
`149`		`- return RubyString.newStringNoCopy(runtime, ByteList.plain(toHex(val)));`
	`150`	`+ return RubyString.newStringNoCopy(runtime, new ByteList(ByteList.plain(toHex(val)), USASCIIEncoding.INSTANCE));`
`150`	`151`	`}`
`151`	`152`
`152`	`153`	`@JRubyMethod(name = "hexencode", required = 1, meta = true)`