-
-
Notifications
You must be signed in to change notification settings - Fork 921
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "[Truffle] - Adds Random class"
This reverts commit 245279f. We're going to use the Rubinius implementation, so no need for all of this boilerplate code.
- Loading branch information
Showing
5 changed files
with
2 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 0 additions & 6 deletions
6
truffle/src/main/java/org/jruby/truffle/nodes/core/RandomNodes.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 0 additions & 18 deletions
18
truffle/src/main/java/org/jruby/truffle/runtime/core/RubyRandom.java
This file was deleted.
Oops, something went wrong.
8bfaa93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucasallan I think you and @chrisseaton discussed moving this to Rubinius. If I'm wrong about that, apologies for the revert. However, this was causing a FindBugs issue and as such, failing the build on Travis.
8bfaa93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nirvdrum Yes, we have discussed it and I have a pull request almost ready (with the rubinius code). Thank you for revert it and apologize for the mistake.
8bfaa93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. I just wanted to make sure I didn't misunderstand.