Skip to content

Commit

Permalink
when jruby is not coming from the thread.currentThread.contextClassLo…
Browse files Browse the repository at this point in the history
…ader then ScriptingContainer

does not work out of the box, dito with JRubyEngineFactory using a wrong value or 'none' value for the classloader
system property (org.jruby.embed.classloader)
  • Loading branch information
mkristian committed Nov 5, 2014
1 parent aaa9628 commit 9536731
Showing 1 changed file with 104 additions and 0 deletions.
104 changes: 104 additions & 0 deletions core/src/test/java/org/jruby/embed/ParentClassLoaderTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
package org.jruby.embed;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.fail;

import java.net.URL;
import java.net.URLClassLoader;

import javax.script.ScriptEngine;
import javax.script.ScriptEngineManager;

import org.jruby.embed.jsr223.JRubyEngineFactory;
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.FixMethodOrder;
import org.junit.Test;
import org.junit.runners.MethodSorters;

@FixMethodOrder(MethodSorters.NAME_ASCENDING) // we need the last test method to run last
public class ParentClassLoaderTest {

static ClassLoader cl;

@BeforeClass
public static void setupClassLoader() {
cl = Thread.currentThread().getContextClassLoader();
// make sure we have classloader which does not find jruby
ClassLoader c = new URLClassLoader( new URL[] {}, null );
try {
c.loadClass( "org.jruby.embed.ScriptingContainer" );
fail( "this classloader shall not find jruby" );
}
catch( ClassNotFoundException expected){}
// set it as context classloader
Thread.currentThread().setContextClassLoader( c );
}

@AfterClass
public static void restClassLoader() {
Thread.currentThread().setContextClassLoader( cl );
}

@Test
public void test1ScriptingContainer() throws Exception {
try {
// we do have an instance of "jruby" loaded via some other classloader
ScriptingContainer instance = new ScriptingContainer(LocalContextScope.CONCURRENT);
instance.runScriptlet( "$LOAD_PATH" ).toString();
fail("should not come here");
}
catch(Exception e){
//expected
}
}

@Test
public void test2JRubyEngineFactoryWithWrongPropertyNameCanFail() throws Exception {
try {
System.setProperty(PropertyName.CLASSLOADER.toString(), "something");
// we do have an instance of "jruby" loaded via some other classloader
ScriptEngineManager m = new ScriptEngineManager();
m.registerEngineName( "jruby", new JRubyEngineFactory() );
ScriptEngine jruby = m.getEngineByName("jruby");
jruby.eval("$LOAD_PATH" ).toString();
fail("should not come here");
}
catch(Exception e){
//expected
}
}

@Test
public void test3JRubyEngineFactoryWithNoneClassloaderPropertyNameCanFail() throws Exception {
try {
System.setProperty(PropertyName.CLASSLOADER.toString(), "none");
// we do have an instance of "jruby" loaded via some other classloader
ScriptEngineManager m = new ScriptEngineManager();
m.registerEngineName( "jruby", new JRubyEngineFactory() );
ScriptEngine jruby = m.getEngineByName("jruby");
jruby.eval("$LOAD_PATH" ).toString();
fail("should not come here");
}
catch(Exception e){
//expected
}
}

@Test
// this test needs to be the last since JRubyEngineFactory uses ScriptingContainer with singleton
// context scope, i.e. once the classloader is setup correctly it remains as it is
public void test4JRubyEngineFactory() throws Exception {
System.getProperties().remove(PropertyName.CLASSLOADER.toString());
// we do have an instance of "jruby" loaded via some other classloader
ScriptEngineManager m = new ScriptEngineManager();
m.registerEngineName( "jruby", new JRubyEngineFactory() );
ScriptEngine jruby = m.getEngineByName("jruby");
String result = jruby.eval("$LOAD_PATH" ).toString();
assertNotNull(result);

assertEquals(jruby.eval("JRuby.runtime.jruby_class_loader.parent" ), cl );
}

}

0 comments on commit 9536731

Please sign in to comment.