Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist artifacts must not install jruby-launcher #1001

Closed
headius opened this issue Sep 10, 2013 · 1 comment
Closed

dist artifacts must not install jruby-launcher #1001

headius opened this issue Sep 10, 2013 · 1 comment
Milestone

Comments

@headius
Copy link
Member

@headius headius commented Sep 10, 2013

In 1717ec9, @mkristian committed a patch to make dist artifacts use bin/jruby.bash for bin/jruby, but that is not sufficient to solve #990.

When the jruby-launcher gem installs, it modifies our RubyGems defaults to start using the full path to jruby in the binstubs it installs instead of using /usr/bin/env. Because in dist artifacts, the bin/jruby is a bash script, it can't be used directly in shebang lines.

Illustrated:

system ~/projects/jruby-versions/jruby-1.7.5.dev $ bin/jruby -S gem install bundler
Fetching: bundler-1.3.5.gem (100%)
Successfully installed bundler-1.3.5
1 gem installed

system ~/projects/jruby-versions/jruby-1.7.5.dev $ head -10 bin/bundle 
#!/Users/headius/projects/jruby-versions/jruby-1.7.5.dev/bin/jruby
#
# This file was generated by RubyGems.
#
# The application 'bundler' is installed as part of a gem, and
# this file is here to facilitate running it.
#

require 'rubygems'


system ~/projects/jruby-versions/jruby-1.7.5.dev $ bin/bundle -v
bin/bundle: line 9: require: command not found
bin/bundle: line 11: version: command not found
bin/bundle: line 15: syntax error near unexpected token `('
bin/bundle: line 15: `  str = str.dup.force_encoding("BINARY") if str.respond_to? :force_encoding'

The dist artifacts need to avoid installing jruby-launcher altogether to avoid rewriting those defaults, or the defaults need to be restored in some way. The latter sounds like the simplest, and it's what our old dist logic did.

mkristian added a commit that referenced this issue Sep 12, 2013
@mkristian
Copy link
Member

@mkristian mkristian commented Sep 13, 2013

fixed via 5a5f63d

@mkristian mkristian closed this Sep 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants