Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit c7c7c7 broke AppEngine #1148

Closed
raphael opened this issue Oct 22, 2013 · 3 comments
Closed

Commit c7c7c7 broke AppEngine #1148

raphael opened this issue Oct 22, 2013 · 3 comments
Milestone

Comments

@raphael
Copy link

@raphael raphael commented Oct 22, 2013

AppEngine does not support the ProcessBuilder and ProcessBuilder.Redirect classes (see https://developers.google.com/appengine/docs/java/jrewhitelist for the list of supported classes) which is now used by the kernel process_manager.rb file to implement the ` (backtick) operator (see SHA: c7c7c7d). This means that any JRuby web application compiled with newer JRuby versions won't load on GAE.

While it may not be practical to cater for every runtime environments from a pragmatic standpoint making it so that the backtick operator does not rely on ProcessBuilder (or at least does not require it, there could be an alternate implemention in case it's missing, such as the previous one) would enable a fairly important use case.

This is a tricky one and clearly the blame is not on JRuby but as a feature request supporting GAE would be awesome!

@headius
Copy link
Member

@headius headius commented Oct 22, 2013

Ahh...so the fact that we even access that class is causing it to blow up.

I'll look into making that fail quietly.

@headius headius closed this in adc0307 Oct 22, 2013
@raphael
Copy link
Author

@raphael raphael commented Oct 22, 2013

Wow, thank you for the quick response! I'll give this a shot and will update with my findings.

@raphael
Copy link
Author

@raphael raphael commented Oct 23, 2013

Happy to report that the fix works (now I'm having to fight a different issue where GAE doesn't allow creating raw threads which jruby-rack depends on...). Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants