Too many files in JRuby 1.7.6 #1151

Closed
cfbrobak opened this Issue Oct 23, 2013 · 6 comments

Comments

Projects
None yet
4 participants
@cfbrobak

jruby 1.7.6 (1.9.3p392) 2013-10-22 6004147 on Java HotSpot(TM) Client VM 1.7.0_40-b43 [Windows XP-x86]

A number of extra/erroneous launch scripts are found in directory "bin/". Some examples:

  • autospec.bat
  • bundle.bat
  • erubis.bat
  • rails.bat
  • rspec.bat
  • sprockets.bat

This problem is probably a result of trying to fix Issue #1138.

@mkristian

This comment has been minimized.

Show comment
Hide comment
@mkristian

mkristian Oct 23, 2013

Member

I guess I need to cherry pick the bat files we want in dist and not bin/*bat

Member

mkristian commented Oct 23, 2013

I guess I need to cherry pick the bat files we want in dist and not bin/*bat

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Oct 23, 2013

Member

Yeah I did notice this AFTER the release dropped. Thanks for filing an issue on it :)

Member

enebo commented Oct 23, 2013

Yeah I did notice this AFTER the release dropped. Thanks for filing an issue on it :)

@mub

This comment has been minimized.

Show comment
Hide comment
@mub

mub Oct 23, 2013

those seem like gem executables, how about adding:

jgem uninstall -ax autospec bundle erubis rails rspec sprockets

To the distribution build script. That would remove other dangling components of those gems.

mub commented Oct 23, 2013

those seem like gem executables, how about adding:

jgem uninstall -ax autospec bundle erubis rails rspec sprockets

To the distribution build script. That would remove other dangling components of those gems.

@mkristian

This comment has been minimized.

Show comment
Hide comment
@mkristian

mkristian Oct 24, 2013

Member

well that list will depend on @enebo what he has installed. but we are able to pick the right unix pieces so I guess we can do the same for those bat files ;)

Member

mkristian commented Oct 24, 2013

well that list will depend on @enebo what he has installed. but we are able to pick the right unix pieces so I guess we can do the same for those bat files ;)

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Oct 24, 2013

Member

Yeah this solution looks the best even if it means needing to update this list if we change what we ship as part of the dist. The other solution is for me to do a shallow clone (I used to do this pre-Maven) so that then env is truly pristine. I am lazy and I think this addresses the problem. It also addresses dev-gem install binstubs which may magically appear if we add another dev gem at a later date.

Member

enebo commented Oct 24, 2013

Yeah this solution looks the best even if it means needing to update this list if we change what we ship as part of the dist. The other solution is for me to do a shallow clone (I used to do this pre-Maven) so that then env is truly pristine. I am lazy and I think this addresses the problem. It also addresses dev-gem install binstubs which may magically appear if we add another dev gem at a later date.

@mkristian

This comment has been minimized.

Show comment
Hide comment
@mkristian

mkristian Oct 24, 2013

Member

I guess the shallow clone is a good idea anyways ;)
would have avoided the jruby-jars bug as well #1152

Member

mkristian commented Oct 24, 2013

I guess the shallow clone is a good idea anyways ;)
would have avoided the jruby-jars bug as well #1152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment