Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many files in JRuby 1.7.6 #1151

Closed
cfbrobak opened this issue Oct 23, 2013 · 6 comments
Closed

Too many files in JRuby 1.7.6 #1151

cfbrobak opened this issue Oct 23, 2013 · 6 comments
Milestone

Comments

@cfbrobak
Copy link

@cfbrobak cfbrobak commented Oct 23, 2013

jruby 1.7.6 (1.9.3p392) 2013-10-22 6004147 on Java HotSpot(TM) Client VM 1.7.0_40-b43 [Windows XP-x86]

A number of extra/erroneous launch scripts are found in directory "bin/". Some examples:

  • autospec.bat
  • bundle.bat
  • erubis.bat
  • rails.bat
  • rspec.bat
  • sprockets.bat

This problem is probably a result of trying to fix Issue #1138.

@mkristian
Copy link
Member

@mkristian mkristian commented Oct 23, 2013

I guess I need to cherry pick the bat files we want in dist and not bin/*bat

@enebo
Copy link
Member

@enebo enebo commented Oct 23, 2013

Yeah I did notice this AFTER the release dropped. Thanks for filing an issue on it :)

@mub
Copy link

@mub mub commented Oct 23, 2013

those seem like gem executables, how about adding:

jgem uninstall -ax autospec bundle erubis rails rspec sprockets

To the distribution build script. That would remove other dangling components of those gems.

@mkristian
Copy link
Member

@mkristian mkristian commented Oct 24, 2013

well that list will depend on @enebo what he has installed. but we are able to pick the right unix pieces so I guess we can do the same for those bat files ;)

mkristian added a commit that referenced this issue Oct 24, 2013
@mkristian mkristian closed this Oct 24, 2013
@enebo
Copy link
Member

@enebo enebo commented Oct 24, 2013

Yeah this solution looks the best even if it means needing to update this list if we change what we ship as part of the dist. The other solution is for me to do a shallow clone (I used to do this pre-Maven) so that then env is truly pristine. I am lazy and I think this addresses the problem. It also addresses dev-gem install binstubs which may magically appear if we add another dev gem at a later date.

@mkristian
Copy link
Member

@mkristian mkristian commented Oct 24, 2013

I guess the shallow clone is a good idea anyways ;)
would have avoided the jruby-jars bug as well #1152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants