Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous files in JRuby 1.7.8 "bin/" directory. #1236

Closed
cfbrobak opened this Issue Nov 18, 2013 · 7 comments

Comments

Projects
None yet
4 participants
@cfbrobak
Copy link

cfbrobak commented Nov 18, 2013

jruby 1.7.8 (1.9.3p392) 2013-11-14 0ce429e on Java HotSpot(TM) Client VM 1.7.0_45-b18 [Windows XP-x86]

The "bin/" directory contains a number of erroneous scripts. These all seem to be using various non-existent (in JRuby distribution) gems:

  • jrubyfx-compile
  • jrubyfx-compile.bat
  • jrubyfx-generator
  • jrubyfx-generator.bat
  • jrubyfx-jarify
  • jrubyfx-jarify.bat
  • jruby_visualizer
  • jruby_visualizer.bat
  • rdoc
  • rdoc.bat
  • ri
  • ri.bat
@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented Nov 19, 2013

all those jruby... files should not be there. pushed a fix for that already.

about the rdoc and ri I am not sure what should be the right thing

@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Nov 21, 2013

I believe rdoc and ri are coming from the rdoc gem. Since this gem is installed by default, it should be OK to have them in the bin archive.

This should explain everything that's listed.

@BanzaiMan BanzaiMan closed this Nov 21, 2013

@cfbrobak

This comment has been minimized.

Copy link
Author

cfbrobak commented Nov 21, 2013

I believe this issue should be reopened.
RDoc is not installed as a gem. It is part of the Standard Library. The launch scripts in the "bin/" directory try to use RDoc installed as a gem instead of using the Standard Library.

@BanzaiMan BanzaiMan reopened this Nov 21, 2013

@ghost ghost assigned mkristian Nov 21, 2013

@headius

This comment has been minimized.

Copy link
Member

headius commented Nov 21, 2013

RDoc is installed as a "default gem", using RubyGems 2.x support for a dummy specification but all code in stdlib. The I believe the logic in bin/ri and bin/rdoc are correct, since they'll either activate the dummy specification or a newer installed version of the rdoc gem.

@headius headius closed this Nov 21, 2013

@headius

This comment has been minimized.

Copy link
Member

headius commented Nov 21, 2013

Do have a look at lib/ruby/gems/shared/gems/rdoc-4.0.1 to see that the only files present are bin/scripts used as stubs for the default gem.

@cfbrobak

This comment has been minimized.

Copy link
Author

cfbrobak commented Nov 21, 2013

I am sorry, but only "rake-10.1.0" is found in that directory:

c:\Apps\jruby-1.7.8\lib\ruby\gems\shared\gems> dir
 Volume in drive C has no label.
 Volume Serial Number is F4F8-152E

 Directory of c:\Apps\jruby-1.7.8\lib\ruby\gems\shared\gems

15-11-2013  07:47    <DIR>          .
15-11-2013  07:47    <DIR>          ..
15-11-2013  07:47    <DIR>          rake-10.1.0
               0 File(s)              0 bytes
               3 Dir(s)  26.755.149.824 bytes free
@headius

This comment has been minimized.

Copy link
Member

headius commented Nov 21, 2013

Ok, this should be filed as a separate issue. The stub gems should be
included in the dist artifact.

Here's my lib/ruby/gems/shared/gems dir from a clean clone of JRuby:

$ ls -l lib/ruby/gems/shared/gems/
total 0
drwxr-xr-x  3 headius  staff  102 Nov 21 03:22 rake-10.1.0
drwxr-xr-x  3 headius  staff  102 Nov 21 01:41 rdoc-4.0.1

Can you file an issue for this, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.