Erroneous files in JRuby 1.7.8 "bin/" directory. #1236

Closed
cfbrobak opened this Issue Nov 18, 2013 · 7 comments

4 participants

@cfbrobak

jruby 1.7.8 (1.9.3p392) 2013-11-14 0ce429e on Java HotSpot(TM) Client VM 1.7.0_45-b18 [Windows XP-x86]

The "bin/" directory contains a number of erroneous scripts. These all seem to be using various non-existent (in JRuby distribution) gems:

  • jrubyfx-compile
  • jrubyfx-compile.bat
  • jrubyfx-generator
  • jrubyfx-generator.bat
  • jrubyfx-jarify
  • jrubyfx-jarify.bat
  • jruby_visualizer
  • jruby_visualizer.bat
  • rdoc
  • rdoc.bat
  • ri
  • ri.bat
@mkristian
JRuby Team member

all those jruby... files should not be there. pushed a fix for that already.

about the rdoc and ri I am not sure what should be the right thing

@BanzaiMan
JRuby Team member

I believe rdoc and ri are coming from the rdoc gem. Since this gem is installed by default, it should be OK to have them in the bin archive.

This should explain everything that's listed.

@BanzaiMan BanzaiMan closed this Nov 21, 2013
@cfbrobak

I believe this issue should be reopened.
RDoc is not installed as a gem. It is part of the Standard Library. The launch scripts in the "bin/" directory try to use RDoc installed as a gem instead of using the Standard Library.

@BanzaiMan BanzaiMan reopened this Nov 21, 2013
@mkristian mkristian was assigned Nov 21, 2013
@headius
JRuby Team member

RDoc is installed as a "default gem", using RubyGems 2.x support for a dummy specification but all code in stdlib. The I believe the logic in bin/ri and bin/rdoc are correct, since they'll either activate the dummy specification or a newer installed version of the rdoc gem.

@headius headius closed this Nov 21, 2013
@headius
JRuby Team member

Do have a look at lib/ruby/gems/shared/gems/rdoc-4.0.1 to see that the only files present are bin/scripts used as stubs for the default gem.

@cfbrobak

I am sorry, but only "rake-10.1.0" is found in that directory:

c:\Apps\jruby-1.7.8\lib\ruby\gems\shared\gems> dir
 Volume in drive C has no label.
 Volume Serial Number is F4F8-152E

 Directory of c:\Apps\jruby-1.7.8\lib\ruby\gems\shared\gems

15-11-2013  07:47    <DIR>          .
15-11-2013  07:47    <DIR>          ..
15-11-2013  07:47    <DIR>          rake-10.1.0
               0 File(s)              0 bytes
               3 Dir(s)  26.755.149.824 bytes free
@headius
JRuby Team member
@mkristian mkristian added a commit that referenced this issue Nov 21, 2013
@mkristian mkristian fix partially #1236 - hopefully the exclude pattern will be generic e…
…nough for future changes ;)
54347f3
@mkristian mkristian added a commit that referenced this issue Nov 21, 2013
@mkristian mkristian fix partially #1236 - hopefully the exclude pattern will be generic e…
…nough for future changes ;)
99cd4fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment