New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to error for unsupported keywords #1368

Closed
headius opened this Issue Dec 29, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@headius
Member

headius commented Dec 29, 2013

Here's two new tests failing for this behavior. I think it was added recently:

  4) Failure:
TestArray#test_sample [/Users/headius/projects/jruby/test/mri/ruby/test_array.rb:2179]:
ArgumentError expected but nothing was raised.

  5) Failure:
TestArray#test_shuffle [/Users/headius/projects/jruby/test/mri/ruby/test_array.rb:2099]:
ArgumentError expected but nothing was raised.
@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Dec 29, 2013

Member

Another:

  9) Failure:
TestDir#test_unknown_keywords [/Users/headius/projects/jruby/test/mri/ruby/test_dir.rb:205]:
[ruby-dev:47152] [Bug #8060].
Expected Exception(ArgumentError) was raised, but the message doesn't match.
Expected /unknown keyword/ to match "wrong number of arguments calling `open` (2 for 1)".
Member

headius commented Dec 29, 2013

Another:

  9) Failure:
TestDir#test_unknown_keywords [/Users/headius/projects/jruby/test/mri/ruby/test_dir.rb:205]:
[ruby-dev:47152] [Bug #8060].
Expected Exception(ArgumentError) was raised, but the message doesn't match.
Expected /unknown keyword/ to match "wrong number of arguments calling `open` (2 for 1)".
@hotaviano

This comment has been minimized.

Show comment
Hide comment
@hotaviano

hotaviano Dec 2, 2014

I want help you, this error still exists ?

hotaviano commented Dec 2, 2014

I want help you, this error still exists ?

@enebo enebo modified the milestone: JRuby 9.0.0.0 Jul 14, 2015

@enebo enebo closed this in df3dd41 Feb 17, 2017

@enebo enebo added this to the JRuby 9.1.8.0 milestone Feb 17, 2017

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Feb 17, 2017

Member

Dir.open missing optional second keyword argument #4495 is for the last case reported in this bug. We just flat out don't support kwarg options for Dir.open at all...

Member

enebo commented Feb 17, 2017

Dir.open missing optional second keyword argument #4495 is for the last case reported in this bug. We just flat out don't support kwarg options for Dir.open at all...

@enebo enebo reopened this Feb 17, 2017

@enebo enebo closed this Feb 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment