Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Dir.home returns LOGDIR env var instead of HOME or user.home #1556

Closed
ledesma opened this Issue · 5 comments

3 participants

@ledesma

While searching for the reason why net/ssh didn't pick up my keys from my home folder, I noticed that Dir.home is pointing to the path defined in the LOGDIR evn variable.

In org.jruby.Rubydir.getHomeDirectoryPath() the order is

  1. LOGDIR
  2. HOME
  3. user.home

According to JRUBY-6295 in Jira it should be

  1. HOME
  2. user.home
  3. LOGDIR

(which makes much more sense).

@lucasallan
Collaborator

I will check it.

@lucasallan
Collaborator

Fixed by 3a1961b
Thanks @ledesma.

@lucasallan lucasallan closed this
@enebo
Owner

@lucasallan Should this be fixed on jruby-1_7 branch as well? Does this logic match 1.8.7 or 1.9.3 behavior? If so you should commit this on that branch as well.

@lucasallan
Collaborator

You're right. I just pushed it to jruby-1_7.

@enebo
Owner

Thanks @lucasallan!

@enebo enebo added this to the JRuby 1.7.12 milestone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.