index.txt for s3 files #1607

Closed
mpapis opened this Issue Apr 2, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@mpapis
Contributor

mpapis commented Apr 2, 2014

forwarding wayneeseguin/rvm#2743 (comment): parsing s3 index is quite slow and is limited, can you provide index.txt with list of all files, for example see http://binaries.rubini.us/index.txt, it would be best if http://jruby.org.s3.amazonaws.com/index.txt would contain list of files in http://jruby.org.s3.amazonaws.com/downloads, but all the files are ok too.

@enebo enebo added this to the JRuby 1.7.12 milestone Apr 2, 2014

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Apr 2, 2014

Member

Ok added and updated in our build scripts so on a release it should be updated:

http://jruby.org.s3.amazonaws.com/downloads/index.txt

Let me know if this is not adequate and I will change things.

Member

enebo commented Apr 2, 2014

Ok added and updated in our build scripts so on a release it should be updated:

http://jruby.org.s3.amazonaws.com/downloads/index.txt

Let me know if this is not adequate and I will change things.

@enebo enebo closed this Apr 2, 2014

@mpapis

This comment has been minimized.

Show comment
Hide comment
@mpapis

mpapis Apr 3, 2014

Contributor

can you also make this file public:

curl -sIL http://jruby.org.s3.amazonaws.com/downloads/index.txt
HTTP/1.1 403 Forbidden
....
Contributor

mpapis commented Apr 3, 2014

can you also make this file public:

curl -sIL http://jruby.org.s3.amazonaws.com/downloads/index.txt
HTTP/1.1 403 Forbidden
....
@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Apr 3, 2014

Member

heh...done.

Member

enebo commented Apr 3, 2014

heh...done.

@mpapis

This comment has been minimized.

Show comment
Hide comment
@mpapis

mpapis Apr 3, 2014

Contributor

awesome, thank you!

Contributor

mpapis commented Apr 3, 2014

awesome, thank you!

esparta added a commit to esparta/jruby that referenced this issue Feb 13, 2018

Improve CSV parsing performance.
  Patch by @joshpencheon (Josh Pencheon)
  [fix GH-1607]

  #### benchmark-ips results
  ```
  trunk:
  Warming up --------------------------------------
                         4.000  i/100ms
  Calculating -------------------------------------
                         39.661  (±10.1%) i/s -      2.352k in 60.034781s
  with-patch:
  Warming up --------------------------------------
                         5.000  i/100ms
  Calculating -------------------------------------
                         60.521  (± 9.9%) i/s -      3.595k in 60.047157s
  ```

  #### memory_profiler resuts

  ```
  trunk:
  allocated memory by class
  -----------------------------------
    35588490  String
     7454320  Array
      294000  MatchData
       37340  Regexp
       11840  Hash
        2400  CSV
        1600  Proc
        1280  Method
         800  StringIO
  with-patch:
  allocated memory by class
  -----------------------------------
    18788490  String
     3454320  Array
      294000  MatchData
       37340  Regexp
       11840  Hash
        2400  CSV
        1600  Proc
        1280  Method
         800  StringIO
  ```

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58777 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Signed-off-by: Espartaco Palma <esparta@gmail.com>

esparta added a commit to esparta/jruby that referenced this issue Feb 13, 2018

Improve CSV parsing performance.
  Patch by @joshpencheon (Josh Pencheon)
  [fix GH-1607]

  #### benchmark-ips results
  ```
  trunk:
  Warming up --------------------------------------
                         4.000  i/100ms
  Calculating -------------------------------------
                         39.661  (±10.1%) i/s -      2.352k in 60.034781s
  with-patch:
  Warming up --------------------------------------
                         5.000  i/100ms
  Calculating -------------------------------------
                         60.521  (± 9.9%) i/s -      3.595k in 60.047157s
  ```

  #### memory_profiler resuts

  ```
  trunk:
  allocated memory by class
  -----------------------------------
    35588490  String
     7454320  Array
      294000  MatchData
       37340  Regexp
       11840  Hash
        2400  CSV
        1600  Proc
        1280  Method
         800  StringIO
  with-patch:
  allocated memory by class
  -----------------------------------
    18788490  String
     3454320  Array
      294000  MatchData
       37340  Regexp
       11840  Hash
        2400  CSV
        1600  Proc
        1280  Method
         800  StringIO
  ```

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58777 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Signed-off-by: Espartaco Palma <esparta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment