Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jruby-openssl gem version inconsitency #1705

Closed
kares opened this Issue May 19, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@kares
Copy link
Member

kares commented May 19, 2014

JRuby 1.7.12 with an empty gemset reports: jruby-openssl (0.9.3)

irb session require 'openssl' and puts Jopenssl::Version::VERSION returns 0.9.4

@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented May 19, 2014

actually this inconsistency got fixed with my last change to use 0.9.5.dev
on the jruby-1_7 branch. in case we switch back to 0.9.4 it will be
consistent.

what you found is the result of taking the openssl from source tree and
deploying 0.9.3 gemspec as default gem.

@kares

This comment has been minimized.

Copy link
Member Author

kares commented May 19, 2014

I see ... 49cded2 fixed it ... thanks.
still seems easy to miss, since it gets updated on 2 places ... but hopefully it will be correct in 1.7.13

any chance more gets into the planned jruby-openssl 0.9.5 (I have a PR open) release ?
... let me know if there's anything I can help you with to get it out and thanks again for the prompt response.

@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented May 19, 2014

yes, there are still files part of git which are built artifacts. and the
jruby/pom.xml needs some attention.

wanted to ask @enebo if releasing jruby-openssl-0.9.5.gem with the next
jruby-1.7.13 is a good plan !

@donv

This comment has been minimized.

Copy link
Member

donv commented May 25, 2014

Hi @mkristian and @enebo !

Will JRuby 1.7.13 get a new version of jruby-openssl? I have a commit that is essential for getting Ruboto to work with SSL.

@mkristian mkristian added this to the JRuby 1.7.13 milestone Jun 19, 2014

@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented Jun 19, 2014

@donv it will ;)

@kares that's fixed now

@mkristian mkristian closed this Jun 19, 2014

@donv

This comment has been minimized.

Copy link
Member

donv commented Jun 21, 2014

Thanks @mkristian !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.