Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no valid struct layout for Ethon::Curl::Slist #1729

Closed
i0rek opened this Issue Jun 6, 2014 · 8 comments

Comments

Projects
None yet
3 participants
@i0rek
Copy link

i0rek commented Jun 6, 2014

Hey,

I get RuntimeError: no valid struct layout for Ethon::Curl::Slist in here: Failing Travis Bulid and I don't have a clue why. It only fails on JRuby, but passes on MRI and Rubinius.

Thanks for your help and your work!

@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented Jun 6, 2014

a local jruby-1.7.12 install worked. using jruby-1.7.4 via rbenv the
default rake also passed all green. now it looks more like a rvm issue (do
not have rvm installed).

the build is quite old, that way I see such an old jruby version. maybe
just trigger ?

@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented Jun 6, 2014

not sure, a newer build all is green with jruby ! am I suppose to look at
the old git history for the issue ?

for my statement before I used the current HEAD of the master branch and
that matches what I see on travis.

@i0rek

This comment has been minimized.

Copy link
Author

i0rek commented Jun 6, 2014

@mkristian thanks for looking into it! I triggered: https://travis-ci.org/typhoeus/ethon/jobs/13720462 and it still fails.

@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented Jun 6, 2014

ok I can reproduce it now, using the branch of that PR - did not see all
this branching business before :(

On Fri, Jun 6, 2014 at 10:11 AM, Hans Hasselberg notifications@github.com
wrote:

@mkristian https://github.com/mkristian thanks for looking into it! I
triggered: https://travis-ci.org/typhoeus/ethon/jobs/13720462 and it
still fails.


Reply to this email directly or view it on GitHub
#1729 (comment).

mkristian added a commit that referenced this issue Jun 6, 2014

mkristian added a commit that referenced this issue Jun 6, 2014

mkristian added a commit that referenced this issue Jun 6, 2014

make the layout lazy on StructByReference to allow to use self.ptr in…
…side the layout. possible fix for #1729

Conflicts:
	spec/ffi/managed_struct_spec.rb

@mkristian mkristian added this to the JRuby 1.7.13 milestone Jun 6, 2014

@enebo enebo modified the milestones: JRuby 1.7.14, JRuby 1.7.13 Jun 24, 2014

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Aug 20, 2014

@mkristian You landed this patch quite a while ago is this issue fixed now?

@i0rek

This comment has been minimized.

Copy link
Author

i0rek commented Aug 21, 2014

that would be awesome!

@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented Aug 21, 2014

yes, should have closed the issue way back

@mkristian mkristian closed this Aug 21, 2014

@i0rek

This comment has been minimized.

Copy link
Author

i0rek commented Aug 21, 2014

@enebo enebo modified the milestones: JRuby 1.7.14, JRuby 1.7.15 Aug 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.