Skip to content

??? jruby-opensll snapshot build not working properly on 1.7 branch #1749

Closed
enebo opened this Issue Jun 16, 2014 · 5 comments

3 participants

@enebo
JRuby Team member
enebo commented Jun 16, 2014

Ok. I landed Kares latest fix on master/ext/openssl and then generated a new snapshot build. I THINK when building on jruby-1_7 branch it is grabbing this snapshot. There is part of this process I don't understand perhaps. Then when I 'ant test-extended' (just copying what travis does) I made to a line like this (I simplified to only have one .rb):

${JRUBY_PROJECT_ROOT}/bin/jruby -I"lib" -X-C  -J-ea -J-cp test:test/target/test-classes:core/target/test-classes --1.8 -I"${JRUBY_PROJECT_ROOT}/lib/ruby/gems/shared/gems/rake-10.1.1/lib" "${JRUBY_PROJECT_ROOT}/lib/ruby/gems/shared/gems/rake-10.1.1/lib/rake/rake_test_loader.rb" "test/test_openssl.rb" 

When I run it:

NameError: cannot load Java class org.jruby.ext.openssl.PEMUtils
         for_name at org/jruby/javasupport/JavaClass.java:1250
  get_proxy_class at org/jruby/javasupport/JavaUtilities.java:34
      java_import at file:/Users/enebo/work/jruby/lib/jruby.jar!/jruby/java/core_ext/object.rb:26
          collect at org/jruby/RubyArray.java:2399
      java_import at file:/Users/enebo/work/jruby/lib/jruby.jar!/jruby/java/core_ext/object.rb:22
           PKCS12 at /Users/enebo/work/jruby/lib/ruby/shared/openssl/pkcs12.rb:11
          OpenSSL at /Users/enebo/work/jruby/lib/ruby/shared/openssl/pkcs12.rb:4
           (root) at /Users/enebo/work/jruby/lib/ruby/shared/openssl/pkcs12.rb:3
          require at org/jruby/RubyKernel.java:1057
           (root) at /Users/enebo/work/jruby/lib/ruby/shared/jopenssl/load.rb:1
          require at org/jruby/RubyKernel.java:1057
           (root) at /Users/enebo/work/jruby/lib/ruby/shared/jopenssl/load.rb:22
          require at org/jruby/RubyKernel.java:1057
           (root) at /Users/enebo/work/jruby/lib/ruby/shared/openssl.rb:1
          require at org/jruby/RubyKernel.java:1057
           (root) at /Users/enebo/work/jruby/lib/ruby/shared/openssl.rb:1
           select at org/jruby/RubyArray.java:2468
           (root) at /Users/enebo/work/jruby/test/test_openssl.rb:1

Is this a new issue or am I making an environment mistake? I used to be against us moving ext/openssl out of jruby repo and now I cannot wait to move it in this multi-branch world. dogs and cats...

PS- Changing to --1.9 does not change the result. Something basic about loading jossl jar (PEMUtils.class is there too).

@enebo enebo added this to the JRuby 1.7.13 milestone Jun 16, 2014
@mkristian
JRuby Team member
@kares
JRuby Team member
kares commented Jun 18, 2014

really strange, @mkristian even tried to remove it at 6a4cca9 but it's really not the fix we want, I'm guessing it's not the correct .jar that was getting loaded (one without a PEMUtils.class) - maybe I would manually cleanup all local openssl snapshots from maven etc.

p.s. regarding moving ext/openssl out again, please retain all of the relevant git history, should be also possible to reconnect the "lost" history back (was moved in by simply copying over from the standalone git repo) .. after there's a release I'm willing to do it - just let me know when you guys are ready (no commits to be expected under ext/openssl path).

@mkristian
JRuby Team member

yes, it was my doing with packing the wrong jar and upload that even to oss.sonatype.org

is on the good side again.

about the move to its own repo: as far I know there are no objections after the release of jruby-openssl.gem and jruby-1.7.13 and all this jruby/ext directory

@mkristian mkristian closed this Jun 18, 2014
@enebo
JRuby Team member
enebo commented Jun 18, 2014

Yeah moving the repository is fine but and the history being preserved is pretty important for this extension based on the overall complexity of supporting openssl.

@kares
JRuby Team member
kares commented Jun 18, 2014

definitely willing/going to do that (have some "crazy" git history extraction experience). in case I forget just ping me ... what I'd like to see is reconnect with the "old" history - before it was simply copied here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.