Time.now + bignum incorrect #1779
Comments
??? which jruby version did you use. a quick test with jruby-1.7.12 showed the |
Maybe try a bigger number? It might depend on your time. I'm using jruby-1.7.3, and also noticed the problem on whatever version of jruby travis-ci uses.
|
hmm - that is fixed from jruby-1.7.5 onwards. 1.7.3 feels really old by now ;) regarding travis I guess you have to report it to there. I did see travis running old jruby versions somewhere before. |
I get different results from jruby-1.7.5 onwards, but not correct results.
|
sorry - did not use big enough numbers to add ;) |
I was using the smallest number possible that would show the overflow. Looks like JRuby 1.7.5, instead of overflowing and going negative, just reaches the max date and stops. |
https://jira.codehaus.org/browse/JRUBY-7095 looks related. |
I believe @joevandyk's analysis is correct and makes this bug still valid against JRuby 9.0.0.0 On MRI That ain't right |
try harder to avoid long overflow in Time#+ (fixes #1779)
thanks @headius ! |
The text was updated successfully, but these errors were encountered: