RbConfig::CONFIG is missing entry for vendordir (and some related entries based off this) #1826

Closed
enebo opened this Issue Jul 17, 2014 · 5 comments

Comments

Projects
None yet
4 participants
@enebo
Member

enebo commented Jul 17, 2014

Current version of rubygems does not run without this (though they will be making a small workaround for us for the time being). Might as well audit some other keys in here since we seem to be missing lots of keys. The specific one causing problems is:

"vendordir"=>"/Users/enebo/Developer/.rvm/rubies/ruby-1.9.3-p547/lib/ruby/vendor_ruby"

@enebo enebo added core labels Jul 17, 2014

@enebo enebo added this to the JRuby 1.7.14 milestone Jul 17, 2014

@drbrain

This comment has been minimized.

Show comment
Hide comment

@enebo enebo modified the milestones: JRuby 1.7.14, JRuby 1.7.15 Aug 27, 2014

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Nov 12, 2014

Member

We do supply vendordir when it is configured via a flag or property. That was requested by some Linux package maintainers. But I'm not sure if we have to provide it. It would seem especially strange to provide it when we don't put it in LOAD_PATH, which is exactly why it's configurable.

Member

headius commented Nov 12, 2014

We do supply vendordir when it is configured via a flag or property. That was requested by some Linux package maintainers. But I'm not sure if we have to provide it. It would seem especially strange to provide it when we don't put it in LOAD_PATH, which is exactly why it's configurable.

@kares kares modified the milestones: JRuby 1.7.15, Won't Fix Mar 1, 2018

@kares kares added the JRuby 1.7.x label Mar 1, 2018

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Mar 1, 2018

Member

@enebo do you feel like this is still relevant or a 1.7 piece to be closed?

Member

kares commented Mar 1, 2018

@enebo do you feel like this is still relevant or a 1.7 piece to be closed?

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Mar 1, 2018

Member

I mean still no RbConfig::CONFIG['vendordir'] but not one complains thus no problem :)

Member

kares commented Mar 1, 2018

I mean still no RbConfig::CONFIG['vendordir'] but not one complains thus no problem :)

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Mar 19, 2018

Member

Example of enabling vendordir and friends using the Java properties we added.

$ jruby -J-Dvendor.dir.general=../jruby/lib -e "puts RbConfig::CONFIG['vendordir']"
../jruby/lib/ruby/stdlib/vendor_ruby

It seems to mess something up if you point it at an empty dir, though:

$ jruby -J-Dvendor.dir.general=/tmp -e "puts RbConfig::CONFIG['vendordir']"
NameError: uninitialized constant RbConfig
  const_missing at org/jruby/RubyModule.java:3411
         <main> at -e:1

We added the property because some JRuby distributors wanted a vendor dir, so I think we can call this one done a long time ago.

Member

headius commented Mar 19, 2018

Example of enabling vendordir and friends using the Java properties we added.

$ jruby -J-Dvendor.dir.general=../jruby/lib -e "puts RbConfig::CONFIG['vendordir']"
../jruby/lib/ruby/stdlib/vendor_ruby

It seems to mess something up if you point it at an empty dir, though:

$ jruby -J-Dvendor.dir.general=/tmp -e "puts RbConfig::CONFIG['vendordir']"
NameError: uninitialized constant RbConfig
  const_missing at org/jruby/RubyModule.java:3411
         <main> at -e:1

We added the property because some JRuby distributors wanted a vendor dir, so I think we can call this one done a long time ago.

@headius headius closed this Mar 19, 2018

@headius headius modified the milestones: Won't Fix, JRuby 9.0.0.0 Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment