Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScriptingContainer.parse(PathType.CLASSPATH, "some.rb").run() fails #1869

Closed
mkristian opened this Issue Jul 29, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@mkristian
Copy link
Member

mkristian commented Jul 29, 2014

org.jruby.embed.EvalFailedException: (TypeError) can't convert nil into String
    at org.jruby.embed.internal.EmbedEvalUnitImpl.run(EmbedEvalUnitImpl.java:133)
    at org.sonatype.nexus.ruby.DefaultRubygemsGateway.newScript(DefaultRubygemsGateway.java:48)

the code is: https://github.com/sonatype/nexus-ruby-support/blob/master/nexus-ruby-tools/src/main/java/org/sonatype/nexus/ruby/DefaultRubygemsGateway.java#L48

during the test the script lives on the currentThread.contextClassloader on production it will live inside an OSGi bundle.

works just fine with jruby-1.7.12 - jruby-1.7.13 already fails the same the current 1.7.14-SNAPSHOT

@mkristian mkristian added this to the JRuby 1.7.14 milestone Jul 29, 2014

@enebo enebo modified the milestones: JRuby 1.7.14, JRuby 1.7.15 Aug 27, 2014

@mkristian mkristian modified the milestones: JRuby 1.7.17, JRuby 1.7.15 Dec 3, 2014

@mkristian

This comment has been minimized.

Copy link
Member Author

mkristian commented Dec 3, 2014

not using it anymore but could be still a problem

@mkristian

This comment has been minimized.

Copy link
Member Author

mkristian commented Dec 3, 2014

looks related #1875

@headius

This comment has been minimized.

Copy link
Member

headius commented Dec 4, 2014

I fixed #1875 but I'm not sure how to test your case, since the file you linked has disappeared. If you can re-test to confirm my fix, I'd appreciate it.

@mkristian

This comment has been minimized.

Copy link
Member Author

mkristian commented Dec 5, 2014

unfortunately this patch alone did not fix jruby enough to run my application: so I did apply #2055 (comment) as well #2197

then fix for #1875 did fix this problem as well.

@mkristian mkristian closed this Dec 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.