Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot builds of jruby-1_7 jruby-jars.gem have the wrong file name #1994

Closed
donv opened this issue Sep 21, 2014 · 6 comments
Closed

Snapshot builds of jruby-1_7 jruby-jars.gem have the wrong file name #1994

donv opened this issue Sep 21, 2014 · 6 comments
Milestone

Comments

@donv
Copy link
Member

@donv donv commented Sep 21, 2014

The gem file name should match the gem version:

1.7.16.dev

jruby-jars-1.7.16.dev.gem

@mkristian I am trying to figure out the build system, but it is proving difficult. What is the Mavenfile for? Removing it makes no difference to the build...

Excerpt from the log:

[INFO]   Successfully built RubyGem
[INFO]   Name: jruby-jars
[INFO]   Version: 1.7.16.dev
[INFO]   File: jruby-jars-1.7.16.dev.gem

That IS the right file name for the gem, but later it is wrong in the pkg directory.

@donv donv added this to the JRuby 1.7.16 milestone Sep 21, 2014
@mkristian
Copy link
Member

@mkristian mkristian commented Sep 22, 2014

$ mvn clean install -Pjruby-jars

poduces:

$ ll maven/jruby-jars/pkg/*gem -rw-rw-r-- 1 christian christian 20124672 Sep 22 09:02 maven/jruby-jars/pkg/jruby-jars-1.7.16.dev.gem

so it does as you asked it to be.

but the rake tasks are not working. I guess they just make no sense anyways since you need a maven build before they actually work and the maven build must run mvn install

the Mavenfile carries some scripts which will be executed in the _verify_ phase. without the Mavenfile this fails. running the _Mavenfile_ directly with rmvn install will generate on the fly the pom.xml as execute this generated pom.xml file.

yes, BUILDING.md on jruby-1_7 is probably behind the master one.

@mkristian
Copy link
Member

@mkristian mkristian commented Sep 22, 2014

$ mvn -Pjruby-jars is the only way to build the gem. closing issue.

@mkristian mkristian closed this Sep 22, 2014
@donv
Copy link
Member Author

@donv donv commented Sep 26, 2014

@mkristian Thanks for the fix! Perfect now!

@mkristian
Copy link
Member

@mkristian mkristian commented Sep 27, 2014

@donv does this also solve the problems you referred on gitter chat ?

@donv
Copy link
Member Author

@donv donv commented Oct 15, 2014

@mkristian yes, I think everything is OK now. Thanks again!

@mkristian
Copy link
Member

@mkristian mkristian commented Oct 16, 2014

hey - I already got an shock reading the headline of this mail. really glad
this things like OK now ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants