Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some pass used by JIT produces code that no longer works in interpreter #2000

Closed
headius opened this issue Sep 25, 2014 · 2 comments
Closed

Some pass used by JIT produces code that no longer works in interpreter #2000

headius opened this issue Sep 25, 2014 · 2 comments
Labels

Comments

@headius
Copy link
Member

@headius headius commented Sep 25, 2014

We talked about this yesterday...when the JIT fails, it does so after it has already run additional passes against the same IR that we would be interpreting. Something in these passes causes that IR to break for the case below when it fails to compile ReceiveKeywordRestArg.

2014-09-25T07:14:08.833-05:00: JITCompiler: could not compile:Open3.Open3.Open3 at /Users/headius/projects/jruby/lib/ruby/2.1/open3.rb:29 because of: "ReceiveKeywordRestArgInstr has no compile logic"
LoadError: load error: open3 -- java.lang.RuntimeException: Should not get here!
     require at org/jruby/RubyKernel.java:926
  __script__ at /Users/headius/projects/jruby/lib/ruby/shared/rubygems/core_ext/kernel_require.rb:55
      (root) at /Users/headius/projects/jruby/lib/ruby/gems/shared/gems/rake-10.3.2/lib/rake/cpu_counter.rb:4
     require at org/jruby/RubyKernel.java:926
  __script__ at /Users/headius/projects/jruby/lib/ruby/shared/rubygems/core_ext/kernel_require.rb:55
      (root) at /Users/headius/projects/jruby/lib/ruby/gems/shared/gems/rake-10.3.2/lib/rake.rb:1
     require at org/jruby/RubyKernel.java:926
  __script__ at /Users/headius/projects/jruby/lib/ruby/shared/rubygems/core_ext/kernel_require.rb:55
      (root) at /Users/headius/projects/jruby/lib/ruby/gems/shared/gems/rake-10.3.2/lib/rake.rb:48
        load at org/jruby/RubyKernel.java:941
  __script__ at /Users/headius/projects/jruby/bin/rake:23

To triger this again, here's the command line I used. You'll want to run it on JRuby prior to a commit I'm about to make that fixes this instr in the JIT.

jruby -Xjit.threshold=0 -Xcompile.invokedynamic=true -Xjit.logging=true -S rake -T

Or you can probably just add the JIT passes to the interpreter passes and try requiring "open3.rb".

cc @subbuss @enebo

@headius headius added the ir label Sep 25, 2014
@headius headius added this to the JRuby 9000 milestone Sep 25, 2014
@headius
Copy link
Member Author

@headius headius commented Sep 25, 2014

The keyrest fix is in 6f40ed6.

@headius
Copy link
Member Author

@headius headius commented Jan 15, 2015

We now clone the instructions for interpreter so the JIT does not affect it. We know we have to keep it that way for thread-safety and other reasons, so I'm going to call this fixed.

The general case -- that passes should always produce code that can be jitted or interpreted -- is known to us and when we have specific cases we'll fix them.

@headius headius closed this as completed Jan 15, 2015
@headius headius removed this from the JRuby 9.0.0.0 milestone Jan 16, 2015
@headius headius added this to the JRuby 9.0.0.0-pre1 milestone Jan 16, 2015
@headius headius added this to the JRuby 9.0.0.0-pre1 milestone Jan 16, 2015
@headius headius removed this from the JRuby 9.0.0.0 milestone Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant