Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
The cases in question are in mri/ruby/test_syntax and look basically like this:
def foo(var = var) ...
def foo(var: defined?(var)) ...
...and so on. This will likely require parser changes. I am excluding test_keyword_self_reference and test_optional_self_reference now.
Note that test_keyword_self_reference actually triggers a Java exception inside IR:
Java::JavaLang::ClassCastException: org.jruby.ir.operands.UndefinedValue cannot be cast to org.jruby.RubyBasicObject
The text was updated successfully, but these errors were encountered:
Exclude some minor syntax failures (#2124, #2126, #2127)
That seems weird ...
Sorry, something went wrong.
Mask out missing parser warning failures. #2124
Ignore the missing parser warning commit. It was meant for #2147.
Coming back to this, I don't think it's an IR issue (at least, it's not anymore)...I think it's a parsing issue.
If the RHS in def foo(var = var) parsed properly, as a local variable load, IR should fall in line and compile it just fine.
def foo(var = var)
I should have commented on this a long time ago but minimal case for this is 'var = var'. Opt arg is unrelated here. This is something I have always considered as a bug in MRI so I never fixed it but perhaps I should...
I am removing 1.7 as support item here as I am starting to wind down on very unlikely to ever be fixed issues. This has been fixed a while on 9000. Closing.
No branches or pull requests