New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to reject invalid float forms with proper message #2126

Closed
headius opened this Issue Nov 6, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@headius
Member

headius commented Nov 6, 2014

I believe this is a recent change. This case from mri/ruby/test_syntax should pass:

  def test_unexpected_fraction
    msg = /unexpected fraction/
    assert_syntax_error("0x0.0", msg)
    assert_syntax_error("0b0.0", msg)
    assert_syntax_error("0d0.0", msg)
    assert_syntax_error("0o0.0", msg)
    assert_syntax_error("0.0.0", msg)
  end

We do reject the first form, but our error message is wrong ("SyntaxError: -e:1: no . floating literal anymore; put 0 before dot"). I'm not sure about the others.

@headius headius added the parser label Nov 6, 2014

@headius headius added this to the JRuby 9000 milestone Nov 6, 2014

@headius headius changed the title from Failure to reject invalid float forms to Failure to reject invalid float forms with proper message Nov 6, 2014

@enebo enebo modified the milestone: JRuby 9.0.0.0 Jul 14, 2015

@enebo enebo added this to the JRuby 9.1.9.0 milestone Mar 12, 2017

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Mar 12, 2017

Member

This appears to be have been resolved a while ago.

Member

enebo commented Mar 12, 2017

This appears to be have been resolved a while ago.

@enebo enebo closed this Mar 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment