Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
StringLiteral consumers may not be CR-aware #2163
The old StrNode propagated CR from the parser into the eventual String. Our new IR was not doing so until @cheald added it in 1899c26 to fix test_slice in mri/ruby/test_string.rb. However, there may be (are likely) other consumers of StringLiteral that are just going straight for the ByteList.
We need to audit all consumers of StringLiteral and make sure they are made CR-aware.
The changes made in 1899c26 broke the JIT logic because that logic was not re-checking the CR of the string as it is being built...it only checked it based on the operands. So for the moment I'm disabling the optimized ByteList logic in the JIT. That will need to be fixed and restored for this bug.