Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truffle: Kill all other threads when the main thread exits #2165

Closed
chrisseaton opened this Issue Nov 9, 2014 · 1 comment

Comments

Projects
None yet
3 participants
@chrisseaton
Copy link
Contributor

chrisseaton commented Nov 9, 2014

Truffle currently has Java semantics where if the main thread exits, other threads just continue to run. We need the Ruby semantics where the main thread exiting will kill other threads. See the implementation of Thread#kill (in the ThreadNodes class) for a way to do this without any overhead.

@chrisseaton chrisseaton changed the title Kill all other threads when the main thread exists Truffle: Kill all other threads when the main thread exists Nov 9, 2014

@eregon

This comment has been minimized.

Copy link
Member

eregon commented Apr 14, 2015

This was fixed by my commit 491618f.

@eregon eregon closed this Apr 14, 2015

@donv donv changed the title Truffle: Kill all other threads when the main thread exists Truffle: Kill all other threads when the main thread exits Apr 14, 2015

@enebo enebo added this to the 9.0.0.0.pre2 milestone Apr 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.