Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/test_file.rb (jruby-1_7) or test/jruby/test_file.rb (master) has a broken test #2222

Closed
mkristian opened this issue Nov 21, 2014 · 3 comments

Comments

@mkristian
Copy link
Member

@mkristian mkristian commented Nov 21, 2014

on jruby-1_7

bin/jruby test/test_file.rb

and on master

bin/jruby  test/jruby/test_file.rb

fails. which is the correct outcome from the current implementation of jar files on the $LOAD_PATH

BUT running the same test as part of the test-suite passes without error.

so either the LoadService for jar files needs be follow the test or the test follows the current implementation. not sure why the test passes with test-suite.

@mkristian
Copy link
Member Author

@mkristian mkristian commented Nov 21, 2014

@ratnikov I guess this is for you

@ratnikov
Copy link
Contributor

@ratnikov ratnikov commented Dec 5, 2014

I've just done a PR to fix the jar one: #2282

Locally, I still get a lot of weird failures, including due to umask and I don't think any of my changes touched that: https://gist.github.com/ratnikov/d50150730970b7b67564

Are you getting similar errors or maybe those are artifacts of my local machine?

@mkristian
Copy link
Member Author

@mkristian mkristian commented Dec 6, 2014

heh - I did not see the the missing "!/" even though I fixed something similar recently ;)

travis is green, I am going to merge this. thanx

@mkristian mkristian closed this Dec 6, 2014
@enebo enebo added this to the Invalid or Duplicate milestone Dec 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants