Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky tests on Travis #2250

Closed
nirvdrum opened this issue Nov 27, 2014 · 3 comments
Closed

Flaky tests on Travis #2250

nirvdrum opened this issue Nov 27, 2014 · 3 comments

Comments

@nirvdrum
Copy link
Contributor

@nirvdrum nirvdrum commented Nov 27, 2014

I've seen the following tests fail sporadically over the course of today:

PHASE='-Prake -Dtask=spec:regression'

[exec] Failures:
[exec]
[exec] 1) A fiber that is running while its resuming thread receives an exception receives that exception
[exec] Failure/Error: fiber_exceptions.size.should == 100
[exec] expected: 100
[exec] got: 99 (using ==)
[exec] # ./spec/regression/GH-1463_exceptions_propagate_through_fibers_spec.rb:37:in `(root)'
PHASE='-Prake -Dtask=test:mri'

[exec] 1) Error:
[exec] TestSignal#test_signal:
[exec] RuntimeError: Interrupt
[exec] /home/travis/build/jruby/jruby/test/mri/ruby/test_signal.rb:18:in `test_signal'
[exec] org/jruby/RubyProc.java:285:in `call'
PHASE='-Prake -Dtask=spec:regression'

[exec] Failures:
[exec]
[exec] 1) A fiber that is running while its resuming thread receives an exception receives that exception
[exec] Failure/Error: expect(thread_exceptions).to eq []
[exec]
[exec] expected: []
[exec] got: [#<ThreadError: interrupted in SizedQueue#pop>, #<ThreadError: interrupted in SizedQueue#pop>]
[exec]
[exec] (compared using ==)
[exec]
[exec] Diff:
[exec] @@ -1,2 +1,3 @@
[exec] -[]
[exec] +[#<ThreadError: interrupted in SizedQueue#pop>,
[exec] + #<ThreadError: interrupted in SizedQueue#pop>]
[exec] # ./spec/regression/GH-1463_exceptions_propagate_through_fibers_spec.rb:42:in `(root)'

I didn't see an easy way to tag them out for now. But it'd be nice to keep the builds green if the failures are benign. Some of the Fiber ones might be legitimate, however.

@headius
Copy link
Member

@headius headius commented Dec 1, 2014

I'm looking into the fiber/thread failures now on a reserved Travis instance. I can't get them to fail locally :-(

@headius
Copy link
Member

@headius headius commented Dec 1, 2014

I suspect the signal failure is due to Travis being a bit slower and not getting enough time in 0.1 for the signal to route properly. I will see about bumping that up.

@nirvdrum
Copy link
Contributor Author

@nirvdrum nirvdrum commented Jan 15, 2015

These specs have been passing for a while now. Closing.

@enebo enebo added this to the Invalid or Duplicate milestone Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants