OpenStruct equality potential bug

[solnic]

TEST

require 'ostruct'

describe OpenStruct do
  describe '#==' do
    it 'returns true when both are the same' do
      left = OpenStruct.new(name: 'Jane')
      right = OpenStruct.new(name: 'Jane')

      expect(left).to eql(right)
    end
  end
end

RESULT ON MRI 2.1.5p273

.

Finished in 0.00141 seconds (files took 0.16863 seconds to load)
1 example, 0 failures

RESULT ON JRUBY 1.7.16 (1.9.3p392)

F

Failures:

  1) OpenStruct#== returns true when both are the same
     Failure/Error: expect(left).to eql(right)

       expected: #<OpenStruct name="Jane">
            got: #<OpenStruct name="Jane">

       (compared using eql?)

       Diff:
     # ./open_struct_bug.rb:9:in `(root)'

Finished in 0.024 seconds (files took 1.44 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./open_struct_bug.rb:5 # OpenStruct#== returns true when both are the same

[myronmarston]

FWIW, the eql matcher uses eql? for comparisons, not == as your doc string states. Taking RSpec out of the picture, here's the behavior on MRI in IRB:

irb(main):002:0> os1 = OpenStruct.new(name: "Jane")
=> #<OpenStruct name="Jane">
irb(main):003:0> os2 = OpenStruct.new(name: "Jane")
=> #<OpenStruct name="Jane">
irb(main):004:0> os1.eql? os2
=> true
irb(main):005:0> os1 == os2
=> true

Compare that to what happens in irb on JRuby:

irb(main):004:0> os1 = OpenStruct.new(name: "Jane")
=> #<OpenStruct name="Jane">
irb(main):005:0> os2 = OpenStruct.new(name: "Jane")
=> #<OpenStruct name="Jane">
irb(main):006:0> os1.eql? os2
=> false
irb(main):007:0> os1 == os2
=> true

[enebo]

JRuby 1.8 and 1.9 behavior on JRuby 1.7.x matches both 1.8 and 1.9 modes of MRI. MRI 2.0+ changed the behavior of this and master (JRuby 9000) also matches MRI 2.0+. So not fixing to match MRI version compat...