Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRegexp.union [] gives wrong result in ruby 1.8 mode #2295
Comments
enebo
added this to the JRuby 1.7.18 milestone
Dec 9, 2014
rtyler
added
the
JRuby 1.7.x
label
Dec 9, 2014
This comment has been minimized.
This comment has been minimized.
|
Err Fixed in commit 62761f7. |
enebo
closed this
Dec 10, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jeremyevans commentedDec 9, 2014
With jruby 1.7.17 (and going back at least to 1.7.6 and probably longer),
Regexp.union []in ruby 1.8 mode gives//instead of/(?!)/. In ruby 1.9 mode, it gives/(?!)/. MRI 1.8.7 behavior is/(?!)/. So instead of the regexp matching nothing, this bug makes the regexp match everything.While not a security vulnerability itself, this can potentially cause security vulnerabilities, if the result of the
Regexp.union []call is being used as a whitelist filter.