Skip to content

/jruby

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I/O calls do not invalidate `String#ascii_only?` cache #2316

Closed
johnmuhl opened this Issue Dec 13, 2014 · 2 comments

Comments

Assignees
No one assigned
Labels
JRuby 1.7.x core encoding
Projects
None yet
Milestone
  JRuby 1.7.18
2 participants
@johnmuhl @headius
@johnmuhl
Copy link
Contributor

johnmuhl commented Dec 13, 2014

See rubinius/rubinius#3236 reproducable with JRuby 1.7.17 and master.
@headius

This comment has been minimized.

Sign in to view
Copy link
Member

headius commented Dec 15, 2014

Thanks to you and @FooBarWidget for finding this! It also appears to reproduce on JRuby master, which is surprising since I have re-ported much of the IO and encoding logic.

Definitely a big one to fix for 1.7.18.

@headius headius added JRuby 1.7.x core encoding labels Dec 15, 2014

@headius headius added this to the JRuby 1.7.18 milestone Dec 15, 2014

@headius headius closed this in c5207d5 Dec 15, 2014

@headius

This comment has been minimized.

Sign in to view
Copy link
Member

headius commented Dec 15, 2014

Fixed on master. I'll try to make same fix on 1.7 now.

evanphx pushed a commit to ruby/ruby that referenced this issue Dec 15, 2014

headius
* test/ruby/test_io_m17n.rb: Add test for coderange clearing in 
  IO#read with buffer. See jruby/jruby#2316.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
0f99627

headius added a commit that referenced this issue Dec 15, 2014

@headius
Clear code range when modify/expanding string for IO.read(..,buf). 
Fixes #2316.

Test added to MRI in http://mla.n-z.jp/~w3ml/w3ml.cgi/ruby-changes/msg/36766
Loading status checks…
fc05939

@FooBarWidget FooBarWidget referenced this issue Dec 15, 2014

Closed

invalid byte sequence in UTF-8 with passenger 4.0.40 and rack-1.4.5 multipart data #1169

ayumin pushed a commit to ayumin/ruby that referenced this issue Jan 4, 2015

headius
* test/ruby/test_io_m17n.rb: Add test for coderange clearing in 
  IO#read with buffer. See jruby/jruby#2316.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
b6e77df

mmasaki pushed a commit to mmasaki/ruby that referenced this issue May 30, 2015

headius
* test/ruby/test_io_m17n.rb: Add test for coderange clearing in 
  IO#read with buffer. See jruby/jruby#2316.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
6a2434c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.