Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several uninitialized and shadow variable warnings #2318

Closed
djberg96 opened this issue Dec 13, 2014 · 6 comments
Closed

Several uninitialized and shadow variable warnings #2318

djberg96 opened this issue Dec 13, 2014 · 6 comments

Comments

@djberg96
Copy link
Contributor

@djberg96 djberg96 commented Dec 13, 2014

jruby 1.7.16 (1.9.3p392) 2014-09-25 575b395 on Java HotSpot(TM) 64-Bit Server VM 1.7.0_07-b10 +jit [Windows 7-amd64]

C:/jruby-1.7.16/lib/ruby/shared/jar_dependencies.rb:118 warning: instance variable @_jars_home_ not initialized
C:/jruby-1.7.16/lib/ruby/shared/jar_dependencies.rb:87 warning: instance variable @_jars_maven_user_settings_ not initialized
C:/jruby-1.7.16/lib/ruby/shared/jar_dependencies.rb:105 warning: instance variable @_jars_maven_global_settings_ not initialized
C:/jruby-1.7.16/lib/ruby/shared/krypt/codec/hex.rb:65 warning: shadowing outer local variable - data
C:/jruby-1.7.16/lib/ruby/shared/krypt/codec/hex.rb:112 warning: shadowing outer local variable - data
C:/jruby-1.7.16/lib/ruby/shared/krypt/codec/base64.rb:78 warning: shadowing outer local variable -data
C:/jruby-1.7.16/lib/ruby/shared/krypt/codec/base64.rb:130 warning: shadowing outer local variable -data
C:/jruby-1.7.16/lib/ruby/shared/krypt/hmac.rb:53 warning: shadowing outer local variable - new_key
C:/jruby-1.7.16/lib/ruby/gems/shared/gems/jruby-win32ole-0.8.5/lib/win32ole/utils.rb:130 warning: shadowing outer local variable - wtime
C:/jruby-1.7.16/lib/ruby/gems/shared/gems/jruby-win32ole-0.8.5/lib/win32ole/win32ole_event.rb:65 warning: `*' interpreted as argument prefix
C:/jruby-1.7.16/lib/ruby/gems/shared/gems/jruby-win32ole-0.8.5/lib/win32ole/win32ole_type.rb:128\ warning: shadowing outer local variable - wtime

Found when running tests for the net-ping gem.

@headius
Copy link
Member

@headius headius commented Dec 15, 2014

These are all external libraries, though we own jruby-win32ole and @mkristian owns jar-dependencies.

Pinging @enebo for jruby-win32ole, @mkristian for jar-dependencies, and @emboss and @vipulnsward for krypt.

@mkristian
Copy link
Member

@mkristian mkristian commented Feb 6, 2015

krypt is gone with any of the next jruby releases since jruby-openssl-0.9.6 does not depend on krypt anymore

@emboss
Copy link

@emboss emboss commented Feb 12, 2015

No action needed for krypt? Or is this still relevant for 1.7.x?

@mkristian
Copy link
Member

@mkristian mkristian commented Feb 18, 2015

@emboss from jruby-openssl-0.9.6 onwards the digest class from krypt was replaced: jruby/jruby-openssl@0bde5e8

no action needed since with the next release of 1.7.20 we ship jruby-openssl-0.9.6

but krypt still relevant for all existing jruby-1.7.x

@djberg96
Copy link
Contributor Author

@djberg96 djberg96 commented Jun 11, 2016

I get the feeling 1.7.x is less and less relevant as time marches on. Should I close this one out?

@djberg96
Copy link
Contributor Author

@djberg96 djberg96 commented Dec 30, 2016

Closing since there's no urgency any more.

@djberg96 djberg96 closed this Dec 30, 2016
@kares kares added this to the Non-Release milestone Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants