Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRUBY_5122 regression spec "write should not block" tests nothing #2332

Open
headius opened this issue Dec 17, 2014 · 0 comments
Open

JRUBY_5122 regression spec "write should not block" tests nothing #2332

headius opened this issue Dec 17, 2014 · 0 comments

Comments

@headius
Copy link
Member

@headius headius commented Dec 17, 2014

The spec for "should not block for write" JRUBY-5122 TCPSocket regression spec does not appear to test anything and occasionally failed due to several inherent races. I improved the race situation somewhat, but it's unclear whether this spec can ever fail since it appears to accept both blocking and nonblocking write.

I believe the spec originally expected small writes not to block, which is reasonable, but at some point it mutated into a test that write does block under certain circumstances, making the original assertions meaningless.

I will remove the spec for now, since there's a large number of other tests that would hang if writes blocked, and the blocking behavior is testing platform-specific buffering behavior external to Ruby.

For this bug, I would like to see confirmation that the assertions this test made tested individually, or else confirm that other suites (MRI/RubySpec) cover them as well or better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant