Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby.newInstance(RubyInstanceConfig) should not unconditionally setGlobalRuntime #2398

Closed
rjnienaber opened this issue Dec 30, 2014 · 0 comments
Closed

Comments

@rjnienaber
Copy link

@rjnienaber rjnienaber commented Dec 30, 2014

From: http://jira.codehaus.org/browse/JRUBY-7082.

Ruby.newInstance(RubyInstanceConfig) should not unconditionally setGlobalRuntime. This is fine for jrubyc, but it should use some other method for standing up a runtime instance. ScriptingContainer when not a SINGLETON ends up starting up potentially n runtimes typically in different classloaders. The terminate() of ScriptingContainer does not unset this (I think you can argue it shouldn't unless global runtime == this) and then leaks a runtime. ScriptingContainer users can Ruby.clearGlobalRuntime() but this is weird.

@rjnienaber rjnienaber closed this Jun 24, 2019
@enebo enebo added this to the Invalid or Duplicate milestone Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants