Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch closure-loading instructions to be operands #2447

Open
headius opened this issue Jan 9, 2015 · 1 comment
Open

Switch closure-loading instructions to be operands #2447

headius opened this issue Jan 9, 2015 · 1 comment

Comments

@headius
Copy link
Member

@headius headius commented Jan 9, 2015

We would like to switch LoadImplicitClosure and LoadFrameClosure to be simple operands, to reduce the complexity of code surrounding them. Unfortunately, in order to make LoadImplicitClosure into an operand (PassedBlock), Operand#retrieve needs to receive the passed block. That cascades into changes to Instr#interpret and callers of each. At the moment it was deemed "polishing the diamond", too big and too risky for too little gain. I will provide a patch based on the almost-complete version (minus the massive refactoring).

@headius
Copy link
Member Author

@headius headius commented Jan 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant