Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect regexp syntax errors in regexp literals at IR build time #2454

Closed
subbuss opened this issue Jan 13, 2015 · 1 comment
Closed

Detect regexp syntax errors in regexp literals at IR build time #2454

subbuss opened this issue Jan 13, 2015 · 1 comment
Labels
ir
Milestone
JRuby 9.0.0.0-pre1

Comments

@subbuss
Copy link
Contributor

@subbuss subbuss commented Jan 13, 2015

From IRBuilder.java:

    // SSS FIXME: Rather than throw syntax error at runtime, we should detect
    // regexp syntax errors at build time and add an exception-throwing instruction instead

This should be fixed before 9k final.
@subbuss subbuss added the ir label Jan 13, 2015
@subbuss subbuss added this to the JRuby 9.0.0.0 milestone Jan 13, 2015
@subbuss
Copy link
Contributor Author

@subbuss subbuss commented Jan 15, 2015

Looks like this is handled in the parser right now. So, this is a non-issue.

@subbuss subbuss closed this as completed Jan 15, 2015
@headius headius removed this from the JRuby 9.0.0.0 milestone Jan 16, 2015
@headius headius added this to the JRuby 9.0.0.0-pre1 milestone Jan 16, 2015
@headius headius added this to the JRuby 9.0.0.0-pre1 milestone Jan 16, 2015
@headius headius removed this from the JRuby 9.0.0.0 milestone Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ir
Projects
None yet
Milestone
JRuby 9.0.0.0-pre1
Development

No branches or pull requests
2 participants
@headius @subbuss