Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RUBY_ENGINE_VERSION #2746

Closed
postmodern opened this issue Mar 23, 2015 · 4 comments
Closed

Support RUBY_ENGINE_VERSION #2746

postmodern opened this issue Mar 23, 2015 · 4 comments
Milestone
Invalid or Duplicate

Comments

@postmodern
Copy link

Rubinius has added support for RUBY_ENGINE_VERSION to help ruby switchers distinguish between the ruby version (1.9.3) and the implementation version (1.7.9). I think JRuby would also benefit from exposing this constant.
@postmodern
Copy link
Author

See also postmodern/chruby#329

@havenwood
Copy link

It would be really nice to have a cross-implementation, standard way of checking the JRUBY_VERSION equivalent. 👍

havenwood added a commit to havenwood/ruby that referenced this issue Mar 23, 2015
@havenwood
Support RUBY_ENGINE_VERSION
1ef0ee0 
`RUBY_ENGINE_VERSION` was [added by Rubinius](rubinius/rubinius@8212c46) for reporting the version of the Ruby engine. It has also [been proposed for JRuby](jruby/jruby#2746), where it would be equivalent to `JRUBY_VERSION`. In CRuby `RUBY_ENGINE_VERSION` would be the same as `RUBY_VERSION`.
@havenwood havenwood mentioned this issue Mar 23, 2015
Closed
@headius
Copy link
Member

headius commented Mar 23, 2015

Seems like a good idea to me...RUBY_ENGINE + RUBY_ENGINE_VERSION is like JVM's java.vm.name and java.vm.version.

@enebo
Copy link
Member

enebo commented Mar 24, 2015

I did not notice this was created yesterday and made my own this morning (and then fixed it): #2751

Closing as dup.

@enebo enebo closed this as completed Mar 24, 2015
@enebo enebo added this to the Invalid or Duplicate milestone Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Invalid or Duplicate
Development

No branches or pull requests
4 participants
@headius @postmodern @enebo @havenwood