Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing event hooks can AIOOB #2903

Closed
enebo opened this issue May 1, 2015 · 2 comments
Closed

Removing event hooks can AIOOB #2903

enebo opened this issue May 1, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@enebo
Copy link
Member

@enebo enebo commented May 1, 2015

Originally from PR #2604 ... I am solving this differently than the original PR. In addition to the original reporters problem of seeing us walk off the edge of the newHooks array this method was also broken because it would not work if the contained hook was not contained in the list.

Testing a fix for this as I write the description. Tip of the hat to @gsamokovarov for the simple reproduction:

require 'coverage'
Coverage.start

set_trace_func proc { |*args| p args }
@enebo enebo added the core label May 1, 2015
@enebo enebo self-assigned this May 1, 2015
@enebo enebo added this to the JRuby 1.7.20 milestone May 1, 2015
@enebo enebo closed this in 8b8d397 May 1, 2015
enebo added a commit that referenced this issue May 1, 2015
@enebo
Copy link
Member Author

@enebo enebo commented May 1, 2015

Cheryy-picked this back to jruby-1_7 as well.

@gsamokovarov
Copy link
Contributor

@gsamokovarov gsamokovarov commented May 2, 2015

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants