Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
In windows ScriptingContainerTest fails #2964
In windows the test testGetCurrentDirectory in ScriptingContainer fails as follows:
The bug appears to be here (org.jruby.util.JRubyFile):
The order of replace is backwards, changing to:
With your permission my coding partner and I would like to use this simple issue to attempt our first contribution to JRuby. Is there a check in guide we should read?
Cris and Greg
Sadly, our proposed solution leads to a different test failing, namely the 'testRequire' test in file 'org.jruby.test.TestKernel'.
We have a proposed fix for that too. Consider the original method:
yields this in windows:
jruby#2964 On windows the mvn -Ptest fails due to incorrect substitution of '/' and '\'. See the write up for more details. Cris Shupp Greg Bowman
I reverted this. It made bundler stop working (surprised revert did not pop up here). I am going to suggest the right fix is to change this test. I think the main meaning of it is to see if we have the same logic File and not exact same string. So:
String expResult = System.getProperty("user.dir"); String result = instance.getCurrentDirectory(); assertEquals(expResult, result);
Maybe should wrap both values as java.io.File() and do some equality check that way.