Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certain require do not load extension Service class #2986

Closed
mkristian opened this issue May 25, 2015 · 2 comments
Closed

certain require do not load extension Service class #2986

mkristian opened this issue May 25, 2015 · 2 comments
Labels
Milestone

Comments

@mkristian
Copy link
Member

@mkristian mkristian commented May 25, 2015

$ bin/jruby -e "require 'uri:classloader:/lib/ruby/shared/json/ext/parser'; p JSON::Ext::Parser"

fails. same with the file:, jar:, file:jar: protocol. the *uri:jar:file:my.jar!/" protocol does not even look into the right place place to load the Service class from the gem extension.

@mkristian
Copy link
Member Author

@mkristian mkristian commented May 25, 2015

I was wrong about the *uri:file: protocol and the wrong place. is part of the test now. closing.

@mkristian mkristian closed this May 25, 2015
@mkristian mkristian reopened this May 26, 2015
@mkristian
Copy link
Member Author

@mkristian mkristian commented May 26, 2015

on master this is already fixed with 764d6af

@headius either I revert this patch and backport master to jruby-1_7 or do the other way around. please also have a look at #2987

in any case I would cherry-pick the tests added with 62fa282

mkristian added a commit that referenced this issue May 26, 2015
Sponsored By Lookout Inc.
mkristian added a commit that referenced this issue May 26, 2015
Sponsored By Lookout Inc.
@mkristian mkristian closed this in 62fa282 May 26, 2015
mkristian added a commit that referenced this issue May 26, 2015
This reverts commit 52eb669.
@enebo enebo added this to the JRuby 9.0.0.0.rc1 milestone Jun 10, 2015
@enebo enebo added the JRuby 9000 label Jun 10, 2015
@mkristian mkristian added JRuby 1.7.x and removed JRuby 9000 labels Jun 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.