New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zlib::GzipReader.readbyte not implemented #3041

Closed
BiraLookout opened this Issue Jun 12, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@BiraLookout

BiraLookout commented Jun 12, 2015

GzipReader doesn't seem to implement readbyte, throwing NoMethodError when called.

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Jun 15, 2015

Member

Looks like it's a trivial wrapper around getbyte.

Member

headius commented Jun 15, 2015

Looks like it's a trivial wrapper around getbyte.

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Jun 15, 2015

Member

Looks like it was added in 1.9, so we should do this for JRuby 1.7.21 too.

Member

headius commented Jun 15, 2015

Looks like it was added in 1.9, so we should do this for JRuby 1.7.21 too.

@headius headius added this to the JRuby 1.7.21 milestone Jun 15, 2015

@headius headius added the stdlib label Jun 15, 2015

headius added a commit that referenced this issue Jun 15, 2015

@headius headius closed this in 158902f Jun 15, 2015

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Jun 15, 2015

Member

I noticed there's no tests for either getbyte or readbyte. Perhaps you'd help us out and add something to https://github.com/ruby/rubyspec?

Member

headius commented Jun 15, 2015

I noticed there's no tests for either getbyte or readbyte. Perhaps you'd help us out and add something to https://github.com/ruby/rubyspec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment