Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixing Hash and keyword arguments raises an error #3138

Closed
robin850 opened this issue Jul 15, 2015 · 4 comments
Closed

Mixing Hash and keyword arguments raises an error #3138

robin850 opened this issue Jul 15, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@robin850
Copy link
Contributor

@robin850 robin850 commented Jul 15, 2015

Hello,

There's a bug with JRuby 9000 when defining a method that mixes a Hash argument with a keyword argument:

>> def foo(bar = {}, baz: nil)
 | end
=> :foo
>> foo({ "foo" => "bar" })
=> ArgumentError: unknown keyword: foo

This is not a problem with MRI.

Have a nice day!

@enebo
Copy link
Member

@enebo enebo commented Jul 15, 2015

Yeah. This is something we know is broken and we discovered it pretty late in development. We will be targeting this in an earlier point release of 9.0.x.y. There are also tagged out specs as well so we have coverage once we do fix this.

@headius headius added this to the JRuby 9.0.1.0 milestone Jul 16, 2015
@enebo enebo modified the milestones: JRuby 9.0.1.0, JRuby 9.0.2.0 Sep 2, 2015
@enebo enebo modified the milestones: JRuby 9.0.5.0, JRuby 9.0.4.0 Nov 12, 2015
@headius
Copy link
Member

@headius headius commented Jan 20, 2016

Still broken as of master today (9.0.5.0).

@headius
Copy link
Member

@headius headius commented Apr 15, 2016

Still failing today, but it won't make 9.1.

@headius headius modified the milestones: JRuby 9.1.1.0, JRuby 9.1.2.0 May 11, 2016
@enebo enebo modified the milestones: JRuby 9.1.2.0, JRuby 9.1.3.0 May 23, 2016
@enebo enebo removed this from the JRuby 9.1.2.0 milestone May 23, 2016
@enebo
Copy link
Member

@enebo enebo commented Aug 23, 2016

Fixed in commit c183943

@enebo enebo closed this Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.