New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixing Hash and keyword arguments raises an error #3138

Closed
robin850 opened this Issue Jul 15, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@robin850
Contributor

robin850 commented Jul 15, 2015

Hello,

There's a bug with JRuby 9000 when defining a method that mixes a Hash argument with a keyword argument:

>> def foo(bar = {}, baz: nil)
 | end
=> :foo
>> foo({ "foo" => "bar" })
=> ArgumentError: unknown keyword: foo

This is not a problem with MRI.

Have a nice day!

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Jul 15, 2015

Member

Yeah. This is something we know is broken and we discovered it pretty late in development. We will be targeting this in an earlier point release of 9.0.x.y. There are also tagged out specs as well so we have coverage once we do fix this.

Member

enebo commented Jul 15, 2015

Yeah. This is something we know is broken and we discovered it pretty late in development. We will be targeting this in an earlier point release of 9.0.x.y. There are also tagged out specs as well so we have coverage once we do fix this.

@headius headius added this to the JRuby 9.0.1.0 milestone Jul 16, 2015

@enebo enebo modified the milestones: JRuby 9.0.1.0, JRuby 9.0.2.0 Sep 2, 2015

@enebo enebo modified the milestones: JRuby 9.0.5.0, JRuby 9.0.4.0 Nov 12, 2015

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Jan 20, 2016

Member

Still broken as of master today (9.0.5.0).

Member

headius commented Jan 20, 2016

Still broken as of master today (9.0.5.0).

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Apr 15, 2016

Member

Still failing today, but it won't make 9.1.

Member

headius commented Apr 15, 2016

Still failing today, but it won't make 9.1.

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Aug 23, 2016

Member

Fixed in commit c183943

Member

enebo commented Aug 23, 2016

Fixed in commit c183943

@enebo enebo closed this Aug 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment