Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9K seems to be handling all jruby.xxx properties #3288

Closed
kares opened this Issue Aug 26, 2015 · 8 comments

Comments

Projects
None yet
3 participants
@kares
Copy link
Member

kares commented Aug 26, 2015

they're used e.g. with gems such as jruby-openssl the jruby.openssl.xxx namespace is used :

:~/workspace/oss/jruby$ jruby -J-Djruby.openssl.debug=true ...
jruby: warning: unknown property jruby.openssl.debug
jruby: warning: unknown property jruby.openssl.debug

... no longer works as it used to on JRuby 1.7

@kares kares added the JRuby 9000 label Aug 26, 2015

@enebo enebo added this to the JRuby 9.0.1.0 milestone Aug 26, 2015

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Aug 26, 2015

@kares perhaps we will just special case anything starting with jruby.openssl. ?

@kares

This comment has been minimized.

Copy link
Member Author

kares commented Aug 26, 2015

how about letting unknown ones through, is that not possible?

@chrisseaton

This comment has been minimized.

Copy link
Contributor

chrisseaton commented Aug 27, 2015

Here's the first weird thing - why is the warning being printed twice? It turns out that JRuby runs processArguments twice!

    at org.jruby.RubyInstanceConfig.processArguments(RubyInstanceConfig.java:166)
    at org.jruby.Main.run(Main.java:224)
    at org.jruby.Main.main(Main.java:197)
    at org.jruby.RubyInstanceConfig.processArguments(RubyInstanceConfig.java:166)
    at org.jruby.Main.doProcessArguments(Main.java:468)
    at org.jruby.Main.internalRun(Main.java:257)
    at org.jruby.Main.run(Main.java:225)
    at org.jruby.Main.main(Main.java:197)

Is that the right behaviour?

@chrisseaton

This comment has been minimized.

Copy link
Contributor

chrisseaton commented Aug 27, 2015

As for actually fixing this issue, I can do two things - we can remove this feature that warns you about an unknown property (and that's all it is by the way - a warning - we don't 'handle' it as in removing it or something like that). But that does seem a shame as I think it's useful. Or we could add a feature that says ignore properties in jruby.openssl.* and some other known patterns. Which do we want?

@kares

This comment has been minimized.

Copy link
Member Author

kares commented Aug 27, 2015

aah, right - there's actually no debug lines to be printed in my script :) ... my bad thought this is more serious. at this point I do not care what the fix is - if its a useful feature for users than keep it and add jruby.openssl.* as a know pattern. maybe jruby-openssl is the only one using the jruby.xxx namespace.

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Aug 27, 2015

@chrisseaton I think we keep going and just add jruby.openssl.* to the exclude list. We could eventually go whole hog and let libraries register these properties but that seems a bit over the top. Let's try something simple as a workaround.

@kares

This comment has been minimized.

Copy link
Member Author

kares commented Aug 28, 2015

@chrisseaton thanks ... and maybe we need another bug for the processArguments going on twice?

@kares

This comment has been minimized.

Copy link
Member Author

kares commented Aug 28, 2015

oh you already did it, just noticed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.