New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3] Missing <<~ heredoc form #3565

Closed
headius opened this Issue Dec 28, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@headius
Member

headius commented Dec 28, 2015

From MRI 2.3 test suite:

SyntaxError: /Users/headius/projects/jruby/test/mri/ruby/test_symbol.rb:168: syntax error, unexpected tLSHFT
    assert_separately([], <<~"end;", timeout: 1) # do

@headius headius added this to the JRuby 9.1.0.0 milestone Dec 28, 2015

enebo added a commit that referenced this issue Feb 4, 2016

Add preliminary support for dedenting heredocs (<<~). Issue #3565.
I am not saying this resolves it because ripper still needs this and
also there is something still broken with mixed interpolated strings
but common cases work and I want to clean the tree for the next
round of fixes.  I also reenabled test_syntax.rb which will add
some failures but we can actually parse this file now :)
@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Apr 1, 2016

Member

[master f568b8d] Fix dstr-laden dedents? Makes all MRI tests pass...It is a little different than MRI in that we compare source line vs wrap in extra arraynodes but I think it is the same? We shall see...

Member

enebo commented Apr 1, 2016

[master f568b8d] Fix dstr-laden dedents? Makes all MRI tests pass...It is a little different than MRI in that we compare source line vs wrap in extra arraynodes but I think it is the same? We shall see...

@enebo enebo closed this Apr 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment