New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override of Gem.path_separator cause gem update --system to fail #3631

Closed
segiddins opened this Issue Feb 1, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@segiddins

segiddins commented Feb 1, 2016

TypeError: no implicit conversion of Regexp into String
          end_with? at org/jruby/RubyString.java:3765
              path= at /Users/segiddins/.gem/jruby/2.2.2/gems/rubygems-update-2.5.2/lib/rubygems/path_support.rb:62
         initialize at /Users/segiddins/.gem/jruby/2.2.2/gems/rubygems-update-2.5.2/lib/rubygems/path_support.rb:35
              paths at /Users/segiddins/.gem/jruby/2.2.2/gems/rubygems-update-2.5.2/lib/rubygems.rb:329
               path at /Users/segiddins/.gem/jruby/2.2.2/gems/rubygems-update-2.5.2/lib/rubygems.rb:352
               dirs at /Users/segiddins/.rubies/jruby-9.0.4.0/lib/ruby/stdlib/rubygems/defaults/jruby.rb:84
              stubs at /Users/segiddins/.gem/jruby/2.2.2/gems/rubygems-update-2.5.2/lib/rubygems/specification.rb:831
               _all at /Users/segiddins/.gem/jruby/2.2.2/gems/rubygems-update-2.5.2/lib/rubygems/specification.rb:725
       latest_specs at /Users/segiddins/.gem/jruby/2.2.2/gems/rubygems-update-2.5.2/lib/rubygems/specification.rb:1123
  find_latest_files at /Users/segiddins/.gem/jruby/2.2.2/gems/rubygems-update-2.5.2/lib/rubygems.rb:467
       load_plugins at /Users/segiddins/.gem/jruby/2.2.2/gems/rubygems-update-2.5.2/lib/rubygems.rb:995
              <top> at /Users/segiddins/.gem/jruby/2.2.2/gems/rubygems-update-2.5.2/lib/rubygems/gem_runner.rb:82
            require at org/jruby/RubyKernel.java:939
             (root) at /Users/segiddins/.gem/jruby/2.2.2/gems/rubygems-update-2.5.2/lib/rubygems/core_ext/kernel_require.rb:1
              <top> at setup.rb:34
@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Feb 1, 2016

Member

you mean this is not really a bug of JRuby's since you set path_separator to a regexp or (pls explain) ?

Member

kares commented Feb 1, 2016

you mean this is not really a bug of JRuby's since you set path_separator to a regexp or (pls explain) ?

@segiddins

This comment has been minimized.

Show comment
Hide comment
@segiddins

segiddins Feb 1, 2016

No, Jruby seems to override that method in its stdlib to return a regexp.

segiddins commented Feb 1, 2016

No, Jruby seems to override that method in its stdlib to return a regexp.

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Feb 2, 2016

Member

@segiddins right, thanks ... JRuby kind of really needs this to be working to handle special cases (that do not happen on MRI) e.g. stdlib packed inside a .jar archive: https://github.com/jruby/jruby/blob/master/lib/ruby/stdlib/rubygems/defaults/jruby.rb#L73-L76 ... has been working for JRuby for a long time, hopefully RGs will resolve this.

Member

kares commented Feb 2, 2016

@segiddins right, thanks ... JRuby kind of really needs this to be working to handle special cases (that do not happen on MRI) e.g. stdlib packed inside a .jar archive: https://github.com/jruby/jruby/blob/master/lib/ruby/stdlib/rubygems/defaults/jruby.rb#L73-L76 ... has been working for JRuby for a long time, hopefully RGs will resolve this.

@segiddins

This comment has been minimized.

Show comment
Hide comment
@segiddins

segiddins Feb 2, 2016

I opened a PR with a bugfix for RubyGems yesterday, just wanted to point out that the bug with Jruby exists.

segiddins commented Feb 2, 2016

I opened a PR with a bugfix for RubyGems yesterday, just wanted to point out that the bug with Jruby exists.

@mkristian

This comment has been minimized.

Show comment
Hide comment
@mkristian

mkristian Feb 2, 2016

Member

@segiddins thanx for the PR on rubygems as the regexp is really important for JRuby and embedded JRuby

Member

mkristian commented Feb 2, 2016

@segiddins thanx for the PR on rubygems as the regexp is really important for JRuby and embedded JRuby

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Mar 4, 2016

Member

This appears to have gone out in RubyGems 2.6.0. I will update to 2.6.1 (latest) on master and 1.7 branches.

Member

headius commented Mar 4, 2016

This appears to have gone out in RubyGems 2.6.0. I will update to 2.6.1 (latest) on master and 1.7 branches.

@headius headius closed this Mar 4, 2016

@headius headius added this to the JRuby 9.1.0.0 milestone Mar 4, 2016

@headius headius added the stdlib label Mar 4, 2016

headius added a commit that referenced this issue Mar 4, 2016

headius added a commit that referenced this issue Mar 4, 2016

headius added a commit that referenced this issue Mar 5, 2016

headius added a commit that referenced this issue Mar 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment