New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set ClassloaderDelegate(false) as default for OSGiIsolatedScriptingContainer + IsolatedScriptingContainer #3682

Closed
mkristian opened this Issue Feb 18, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@mkristian
Member

mkristian commented Feb 18, 2016

OSGiIsolatedScriptingContainer scriptingContainer = new OSGiIsolatedScriptingContainer();
// to avoid verify errors with bouncy castle jars
scriptingContainer.setClassloaderDelegate(false);

we did revert this default on regular jruby runtime to delegate class loading to the parent classloader. there were basically two main reasons for this:
nokogiri using xalan from the jvm which is fixed now with sparklemotion/nokogiri#1212

and joda-time could conflict when joda-time gets required by a runtime - and there is not work around beside ignoring the require on a jruby runtime.

my intention here is more the OSGi case, if I add jruby to an OSGi I just expect it to work and seeing class verify errors on bouncy-castle classes feels like a serious issue.

@mkristian mkristian self-assigned this Feb 18, 2016

@mkristian mkristian added this to the JRuby 9.1.0.0 milestone Feb 18, 2016

@mkristian mkristian closed this in 1910a86 Apr 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment