IO#write_nonblock causes CCE on Windows #3745

Closed
enebo opened this Issue Mar 18, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@enebo
Member

enebo commented Mar 18, 2016

Environment

JRuby 1.7.25 on windows

Expected Behavior

To not crash with a classcastexception.

Actual Behavior

Classcastexception based on wanting a ChannelStream but getting a CRLFStreamWrapper.

@enebo enebo added the windows label Mar 18, 2016

@enebo enebo added this to the JRuby 1.7.25 milestone Mar 18, 2016

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Mar 18, 2016

Member

This causes about 12 specs on spec:ruby19:fast to fail.

Member

enebo commented Mar 18, 2016

This causes about 12 specs on spec:ruby19:fast to fail.

enebo added a commit that referenced this issue Mar 18, 2016

Fixes #3745. IO#block_nonwrite causes CCE on Windows.
I made a marker interface so that both ChannelStream and CRLFStream
wrapper can have a common type so they can call writenonblock.  I added
an error check to throw and IOException if CRLFStreamWrapper is wrapping
from stream type but I suspect it is an impossible path by this point in
our code.  Zero 1.7 risk fix since this was just dumping stack before.

@enebo enebo closed this Mar 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment