New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load path from the command line -I should use the same splitting as for GEM_PATH #3750

Closed
mkristian opened this Issue Mar 22, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@mkristian
Member

mkristian commented Mar 22, 2016

line https://travis-ci.org/jruby/jruby/jobs/117553486#L4709
shows a forked jruby process by rspec/rake

java -cp :/home/travis/build/jruby/jruby/maven/jruby/target/it/runnable/runnable.jar org.jruby.Main -Iuri:classloader:/gems/rspec-core-3.4.3/lib:uri:classloader:/gems/rspec-support-3.4.1/lib uri:classloader://gems/rspec-core-3.4.3/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb

the load-path should use the same regexp for splitting it as we use for GEM_PATH in rubygems.

Environment

jruby-9.1.0.0-SNAPSHOT

Expected Behavior

$LOAD_PATH should be ['uri:classloader:/gems/rspec-core-3.4.3/lib']

Actual Behavior

$LOAD_PATH is ['uri', 'classloader', '/gems/rspec-core-3.4.3/lib']

@mkristian mkristian self-assigned this Mar 22, 2016

@mkristian mkristian added this to the JRuby 9.1.0.0 milestone Mar 22, 2016

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Mar 22, 2016

Member

although $LOAD_PATH doesn't know anything about RubyGems and its spliting logic or does it?

Member

kares commented Mar 22, 2016

although $LOAD_PATH doesn't know anything about RubyGems and its spliting logic or does it?

@mkristian

This comment has been minimized.

Show comment
Hide comment
@mkristian

mkristian Mar 22, 2016

Member

$LOAD_PATH is an array. -Ipath1:path2 commandline switch is the thing which needs the splitting logic

Member

mkristian commented Mar 22, 2016

$LOAD_PATH is an array. -Ipath1:path2 commandline switch is the thing which needs the splitting logic

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Apr 19, 2016

Member

It seems like this logic is there in ArgumentProcessor...

Member

headius commented Apr 19, 2016

It seems like this logic is there in ArgumentProcessor...

@mkristian

This comment has been minimized.

Show comment
Hide comment
@mkristian

mkristian Apr 19, 2016

Member

was fixed by fa4846f

Member

mkristian commented Apr 19, 2016

was fixed by fa4846f

@mkristian mkristian closed this Apr 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment