Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double packaging of `org/joda/time/format/messages.properties` in jruby-jars #3861

Closed
donv opened this issue May 7, 2016 · 11 comments
Closed

Double packaging of `org/joda/time/format/messages.properties` in jruby-jars #3861

donv opened this issue May 7, 2016 · 11 comments

Comments

@donv
Copy link
Member

@donv donv commented May 7, 2016

Environment

  • jruby-jars-9.1.0.0
  • OS X 10.10.5
  • Ruboto 1.5.0

Expected Behavior

No duplicate files in jruby-core vs jruby-stdlib

Actual Behavior

Found duplicate file: org/joda/time/format/messages.properties

When packaging Ruboto applications, this breaks the packaging. Which file should be included in the package?

@donv
Copy link
Member Author

@donv donv commented May 7, 2016

There are several files that are duplicated:

org/joda/time/format/messages*.properties
org/joda/time/tz/data/**/*
@kares
Copy link
Member

@kares kares commented May 8, 2016

hey! there weren't any in 9.0.5.0, right? ... there wasn't much packaging related change as far as I know.

@kares kares added this to the JRuby 9.1.1.0 milestone May 8, 2016
@mkristian
Copy link
Member

@mkristian mkristian commented May 8, 2016

@donv can you please tell me where you got the jruby-stdlib from ? the file from http://repo1.maven.org/maven2/org/jruby/jruby-stdlib/9.1.0.0/ has only files under META-INF directory which look all OK to me.

@headius
Copy link
Member

@headius headius commented May 11, 2016

Not critical for 9.1.1 release. Punting.

@headius headius modified the milestones: JRuby 9.1.2.0, JRuby 9.1.1.0 May 11, 2016
@enebo enebo modified the milestones: JRuby 9.1.2.0, JRuby 9.1.3.0 May 23, 2016
@donv
Copy link
Member Author

@donv donv commented May 30, 2016

I got the files from jruby-jars.gem from rubygems.org and from

http://ci.jruby.org/snapshots/master/jruby-jars-9.1.3.0.SNAPSHOT.gem

@kares
Copy link
Member

@kares kares commented May 30, 2016

for the 9.1.2.0 released jruby-jars gem (from rubygems) I do not see those duplicates in the packed :

kares@sputnik:~/tmp$ jar tvf jruby-core-9.1.2.0-complete.jar | grep messages
   650 Thu May 26 16:49:16 CEST 2016 org/joda/time/format/messages.properties
   663 Thu May 26 16:49:16 CEST 2016 org/joda/time/format/messages_da.properties
   660 Thu May 26 16:49:16 CEST 2016 org/joda/time/format/messages_de.properties
     0 Thu May 26 16:49:16 CEST 2016 org/joda/time/format/messages_en.properties
   665 Thu May 26 16:49:16 CEST 2016 org/joda/time/format/messages_es.properties
   670 Thu May 26 16:49:16 CEST 2016 org/joda/time/format/messages_fr.properties
   658 Thu May 26 16:49:16 CEST 2016 org/joda/time/format/messages_ja.properties
   649 Thu May 26 16:49:16 CEST 2016 org/joda/time/format/messages_nl.properties
  1172 Thu May 26 16:49:16 CEST 2016 org/joda/time/format/messages_pl.properties
   652 Thu May 26 16:49:16 CEST 2016 org/joda/time/format/messages_pt.properties

(no messages*.properties in jruby-stdlib .jar) ... same for the linked SNAPSHOT :

kares@sputnik:~/tmp$ jar tvf jruby-core-9.1.3.0-SNAPSHOT-complete.jar | grep messages
   650 Mon May 30 00:36:54 CEST 2016 org/joda/time/format/messages.properties
   663 Mon May 30 00:36:54 CEST 2016 org/joda/time/format/messages_da.properties
   660 Mon May 30 00:36:54 CEST 2016 org/joda/time/format/messages_de.properties
     0 Mon May 30 00:36:54 CEST 2016 org/joda/time/format/messages_en.properties
   665 Mon May 30 00:36:54 CEST 2016 org/joda/time/format/messages_es.properties
   670 Mon May 30 00:36:54 CEST 2016 org/joda/time/format/messages_fr.properties
   658 Mon May 30 00:36:54 CEST 2016 org/joda/time/format/messages_ja.properties
   649 Mon May 30 00:36:54 CEST 2016 org/joda/time/format/messages_nl.properties
  1172 Mon May 30 00:36:54 CEST 2016 org/joda/time/format/messages_pl.properties
   652 Mon May 30 00:36:54 CEST 2016 org/joda/time/format/messages_pt.properties

did I miss anything?

@mkristian
Copy link
Member

@mkristian mkristian commented May 30, 2016

@kares commit 5c712c5 brought the joda jars into jruby-stdlib which I think gives the error @donv sees as ruboto does unpack all jars found inside the jruby-stdlib

these jars are not needed at all

@kares
Copy link
Member

@kares kares commented May 30, 2016

oh najs ... that maven meta-data part seems scary - good that you kept an eye on that one. thanks!

kares added a commit that referenced this issue Jun 6, 2016
... with 5c712c5

not sure about the cause of why it got packed up (can not reproduce)

see GH-3861
@kares
Copy link
Member

@kares kares commented Jun 6, 2016

did remove joda-time-2.3.jar from stdlib dist. not sure how it got there - thus keeping open just in case.

@headius
Copy link
Member

@headius headius commented Aug 15, 2016

What more do we need to do for this one, @kares?

@kares
Copy link
Member

@kares kares commented Aug 16, 2016

should be good to go ... we can always reopen if its still an issue.

@kares kares closed this Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.