New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport recent File.expand_path and basename encoding fixes #3885

Closed
headius opened this Issue May 12, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@headius
Member

headius commented May 12, 2016

As requested by @enebo we should try to backport the fixes for #3877 and #3866 to 1.7.

The #3866 fix is mostly isolated from joni transcoding, but the #3877 fix would require 1.7 to start using joni for at least the encoding of java.lang.String to unusual target encodings (like Windows-1250).

I started wotking on #3866 but there have been refactorings on 9.1 to negotiate, and there's missing fixes for e.g. the "filesystem" encoding. With all of #3866 naively ported, I was getting NPEs due to a null filesystem encoding.

Regardless, I don't believe it would be a lot of work to get both fixes ported appropriately.

@enebo

This comment has been minimized.

Member

enebo commented May 16, 2017

1.7.x is EOL and this will not get fixed. Marking WONTFIX

@enebo enebo closed this May 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment